Update the documentation of the scatter_ method with support for reduction methods. #40962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… usage details of scatter reduction
v0dro
changed the title
v0dro
changed the title
ngimel
approved these changes
Jul 3, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
Nit: in couple places in #36447 std::string argument is passed by value https://github.com/pytorch/pytorch/pull/36447/files#diff-5312d553f68ae8e12304275aab5ac43cR571 |
Contributor
Author
|
So both these places are functions that are directly placed in |
Contributor
csarofeen
pushed a commit
to csarofeen/pytorch
that referenced
this pull request
Jul 7, 2020
…ction methods. (pytorch#40962) Summary: Follow up to pytorch#36447 . Update for pytorch#33389. Also removes unused `unordered_map` include from the CPP file. Pull Request resolved: pytorch#40962 Differential Revision: D22376253 Pulled By: ngimel fbshipit-source-id: 4e7432190e9a847321aec6d6f6634056fa69bdb8
csarofeen
added a commit
to csarofeen/pytorch
that referenced
this pull request
Aug 16, 2020
…for reduction methods. (pytorch#40962)" This reverts commit 2a04414.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #36447 . Update for #33389.
Also removes unused
unordered_mapinclude from the CPP file.