[NCCL] Add timeout to ProcessGroup Work Wait #40944
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack adds Work-level timeout for blocking wait. This PR just changes the API to accept a default wait arg for the wait function in each ProcessGroup backend. The ProcessGroup superclass correctly waits for the given timeout by changing the CV wait to wait_for. Closes: #37571 Differential Revision: [D22107135](https://our.internmc.facebook.com/intern/diff/D22107135/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22107135/)! [ghstack-poisoned]
This was referenced Jul 2, 2020
💊 CI failures summary and remediationsAs of commit c4d4ddd (more details on the Dr. CI page):
🚧 3 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
This stack adds Work-level timeout for blocking wait. This PR just changes the API to accept a default wait arg for the wait function in each ProcessGroup backend. The ProcessGroup superclass correctly waits for the given timeout by changing the CV wait to wait_for. Closes: #37571 Differential Revision: [D22107135](https://our.internmc.facebook.com/intern/diff/D22107135/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22107135/)! [ghstack-poisoned]
This stack adds Work-level timeout for blocking wait. This PR just changes the API to accept a default wait arg for the wait function in each ProcessGroup backend. The ProcessGroup superclass correctly waits for the given timeout by changing the CV wait to wait_for. Closes: #37571 Differential Revision: [D22107135](https://our.internmc.facebook.com/intern/diff/D22107135/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22107135/)! [ghstack-poisoned]
mrshenli
approved these changes
Jul 7, 2020
This stack adds Work-level timeout for blocking wait. This PR just changes the API to accept a default wait arg for the wait function in each ProcessGroup backend. The ProcessGroup superclass correctly waits for the given timeout by changing the CV wait to wait_for. Closes: #37571 Differential Revision: [D22107135](https://our.internmc.facebook.com/intern/diff/D22107135/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22107135/)! [ghstack-poisoned]
This stack adds Work-level timeout for blocking wait. This PR just changes the API to accept a default wait arg for the wait function in each ProcessGroup backend. The ProcessGroup superclass correctly waits for the given timeout by changing the CV wait to wait_for. Closes: #37571 Differential Revision: [D22107135](https://our.internmc.facebook.com/intern/diff/D22107135/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22107135/)! [ghstack-poisoned]
jiayisuse
approved these changes
Jul 15, 2020
jiayisuse
approved these changes
Jul 15, 2020
This stack adds Work-level timeout for blocking wait. This PR just changes the API to accept a default wait arg for the wait function in each ProcessGroup backend. The ProcessGroup superclass correctly waits for the given timeout by changing the CV wait to wait_for. Closes: #37571 Differential Revision: [D22107135](https://our.internmc.facebook.com/intern/diff/D22107135/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22107135/)! [ghstack-poisoned]
osalpekar
requested review from
apaszke,
ebetica,
goldsborough and
yf225
as code owners
This stack adds Work-level timeout for blocking wait. This PR just changes the API to accept a default wait arg for the wait function in each ProcessGroup backend. The ProcessGroup superclass correctly waits for the given timeout by changing the CV wait to wait_for. Closes: #37571 Differential Revision: [D22107135](https://our.internmc.facebook.com/intern/diff/D22107135/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22107135/)! [ghstack-poisoned]
Contributor
|
This pull request has been merged in 9d92fa2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This stack adds Work-level timeout for blocking wait.
This PR just changes the API to accept a default wait arg for the wait function in each ProcessGroup backend. The ProcessGroup superclass correctly waits for the given timeout by changing the CV wait to wait_for.
Closes: #37571
Differential Revision: D22107135
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!