Skip to content

[quant][graphmode][fix] cloning schema in insert_observers (#40624) #40934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malfet merged 1 commit into from
Jul 7, 2020
Merged

[quant][graphmode][fix] cloning schema in insert_observers (#40624) #40934

malfet merged 1 commit into from
Jul 7, 2020

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jul 2, 2020

Summary:
Pull Request resolved: #40624

Previously we didn't clone schema, so the default schema is used, this is
causing issue for some models

Test Plan: Imported from OSS

Differential Revision: D22259519

fbshipit-source-id: e2a393a54cb18f55da0c7152a74ddc22079ac350

@jerryzh168
[quant][graphmode][fix] cloning schema in insert_observers (#40624)
2d4d37f 
Summary:
Pull Request resolved: #40624

Previously we didn't clone schema, so the default schema is used, this is
causing issue for some models

Test Plan: Imported from OSS

Differential Revision: D22259519

fbshipit-source-id: e2a393a54cb18f55da0c7152a74ddc22079ac350
@jerryzh168 jerryzh168 requested a review from apaszke as a code owner July 2, 2020 19:00
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jul 2, 2020
@jerryzh168 jerryzh168 mentioned this pull request Jul 2, 2020
Closed
@jerryzh168 jerryzh168 added this to the 1.6.0 milestone Jul 2, 2020
@dr-ci
Copy link

dr-ci bot commented Jul 2, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 2d4d37f (more details on the Dr. CI page):

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build caffe2_onnx_main_py3_6_clang7_ubuntu16_04_test (1/1)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun) ❄️

E: Failed to fetch http://us-central1.gce.archive.ubuntu.com/ubuntu/dists/xenial-updates/main/binary-amd64/Packages.xz Hash Sum mismatch 
                                                            83% [8 Sources store 0 B]                           Get:54 http://security.ubuntu.com/ubuntu xenial-security/main amd64 Packages [889 kB] 
                                                            86% [16 Packages store 0 B]                             Get:55 http://security.ubuntu.com/ubuntu xenial-security/main Translation-en [332 kB] 
87% [Waiting for headers] 87% [17 Translation-en store 0 B] [Waiting for headers]                                                         Get:56 http://security.ubuntu.com/ubuntu xenial-security/universe amd64 Packages [495 kB] 
89% [Waiting for headers] 89% [20 Packages store 0 B] [Waiting for headers]                                                   Get:57 http://security.ubuntu.com/ubuntu xenial-security/universe Translation-en [203 kB] 
                                                                  90% [20 Packages store 0 B]                             Get:58 http://security.ubuntu.com/ubuntu xenial-security/multiverse amd64 Packages [6,084 B] 
                                                               90% [20 Packages store 0 B]                             Get:59 http://security.ubuntu.com/ubuntu xenial-security/multiverse Translation-en [2,888 B] 
                                  94% [Working]               Fetched 28.3 MB in 4s (6,437 kB/s) 
Reading package lists... 98%  Reading package lists... Done  
W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: https://cli-assets.heroku.com/apt ./ InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5DC22404A6F9F1CA 
W: Failed to fetch https://cli-assets.heroku.com/apt/./InRelease  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5DC22404A6F9F1CA 
E: Failed to fetch http://us-central1.gce.archive.ubuntu.com/ubuntu/dists/xenial-updates/main/binary-amd64/Packages.xz  Hash Sum mismatch 
W: Some index files failed to download. They have been ignored, or old ones used instead.

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@malfet malfet merged commit a857af5 into release/1.6 Jul 7, 2020
@facebook-github-bot facebook-github-bot deleted the 1.6.fix2 branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @malfet @facebook-github-bot