Skip to content

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Jul 2, 2020

@ssnl ssnl requested a review from apaszke as a code owner July 2, 2020 15:40
@ssnl ssnl requested a review from zou3519 July 2, 2020 15:41
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't actually know what the ivar and vartype does, but the rendered html looks good

image

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ssnl
Copy link
Collaborator Author

ssnl commented Jul 2, 2020

@zou3519 oh wow, is there a CI build that we can use to preview docs?

@zou3519
Copy link
Contributor

zou3519 commented Jul 2, 2020

@ssnl I just built the docs locally lol. But I think you might be able to pull the docker container of pytorch_python_doc_push and grab the html from there (I don't remember if we persist the docs build on success or not). We've been wanting an easy way to preview changes to the docs (#28035) but no one has worked on it

@ssnl
Copy link
Collaborator Author

ssnl commented Jul 2, 2020

@zou3519 oh great :) thanks for building and previewing the docs.

@ssnl ssnl deleted the SsnL-patch-12 branch July 2, 2020 19:49
@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in b678666.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants