[jit] Fix jit not round to even if const is folded #40897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
Contributor
Author
|
@suo @gmagogsfm @fmassa would you mind looking at it? |
gmagogsfm
reviewed
Jul 3, 2020
💊 CI failures summary and remediationsAs of commit 0d2ff45 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 14 times. |
cloudhan
force-pushed
the
fix-jit-roundeven
branch
from
ede07f9 to
97ded94
Compare
gmagogsfm
approved these changes
Jul 7, 2020
and only use the trick to handle halfway values
cloudhan
force-pushed
the
fix-jit-roundeven
branch
from
d1ebc1d to
5f63eee
Compare
gmagogsfm
approved these changes
Jul 14, 2020
| // special halfway case. For positive 'x', round(x/2)*2 = | ||
| // round((x_e + x_r)/2)*2 = x_e + round(x_r/2)*2, where x_e is an even integer, | ||
| // x_r is either 0.5 of 1.5, round(x_r/2)*2 results a 0 or 2, so the final | ||
| // result will always be a even number. Due to symmetric, it also applies to |
Contributor
There was a problem hiding this comment.
s/symmetric/symmetricity
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
Thank you cloudhan for contributing this fix! |
Contributor
|
@gmagogsfm merged this pull request in e44f460. |
fmassa
added a commit
to fmassa/vision-1
that referenced
this pull request
Dec 4, 2020
This has been fixed in PyTorch in pytorch/pytorch#40897
fmassa
added a commit
to fmassa/vision-1
that referenced
this pull request
Dec 4, 2020
This has been fixed in PyTorch in pytorch/pytorch#40897
fmassa
added a commit
to pytorch/vision
that referenced
this pull request
Dec 4, 2020
This has been fixed in PyTorch in pytorch/pytorch#40897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #40771