Skip to content

typing for tensor.T/grad_fn torch.Size #40879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ssnl wants to merge 2 commits into from
Closed

typing for tensor.T/grad_fn torch.Size #40879

ssnl wants to merge 2 commits into from

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Jul 1, 2020

fixes #40658 #40658

@ssnl ssnl requested a review from ezyang July 1, 2020 18:57
facebook-github-bot
facebook-github-bot reviewed Jul 1, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Jul 1, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 87c9f0e (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

@ezyang
Copy link
Contributor

ezyang commented Jul 1, 2020

meh, it didn't typecheck


Jul 01 20:15:53 ======================================================================
Jul 01 20:15:53 FAIL [52.590s]: test_run_mypy (__main__.TestTypeHints)
Jul 01 20:15:53 ----------------------------------------------------------------------
Jul 01 20:15:53 Traceback (most recent call last):
Jul 01 20:15:53   File "test_type_hints.py", line 214, in test_run_mypy
Jul 01 20:15:53     self.fail("mypy failed: {}".format(stdout))
Jul 01 20:15:53 AssertionError: mypy failed: torch/_lowrank.py:63: error: 'int?' object is not iterable  [misc]
Jul 01 20:15:53 torch/_lowrank.py:67: error: Cannot determine type of 'n'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:136: error: 'int?' object is not iterable  [misc]
Jul 01 20:15:53 torch/_lowrank.py:146: error: Cannot determine type of 'm'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:146: error: Cannot determine type of 'n'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:236: error: 'int?' object is not iterable  [misc]
Jul 01 20:15:53 torch/_lowrank.py:239: error: Cannot determine type of 'm'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:239: error: Cannot determine type of 'n'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:240: error: Cannot determine type of 'm'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:240: error: Cannot determine type of 'n'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:243: error: Cannot determine type of 'm'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:243: error: Cannot determine type of 'n'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:256: error: Cannot determine type of 'm'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:264: error: Cannot determine type of 'n'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:266: error: Unsupported left operand type for + (int?)  [operator]
Jul 01 20:15:53 torch/_lowrank.py:266: error: Cannot determine type of 'm'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:270: error: Cannot determine type of 'm'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:271: error: Unsupported left operand type for + (int?)  [operator]
Jul 01 20:15:53 torch/_lowrank.py:271: error: Cannot determine type of 'n'  [has-type]
Jul 01 20:15:53 torch/_lowrank.py:272: error: Unsupported left operand type for + (int?)  [operator]
Jul 01 20:15:53 torch/_C/__init__.pyi:39: error: Variable "torch._C.int" is not valid as a type  [valid-type]
Jul 01 20:15:53 torch/_C/__init__.pyi:39: note: See https://mypy.readthedocs.io/en/latest/common_issues.html#variables-vs-type-aliases
Jul 01 20:15:53 torch/_C/__init__.pyi:44: error: Variable "torch._C.int" is not valid as a type  [valid-type]
Jul 01 20:15:53 torch/_C/__init__.pyi:44: note: See https://mypy.readthedocs.io/en/latest/common_issues.html#variables-vs-type-aliases
Jul 01 20:15:53 Found 22 errors in 2 files (checked 1004 source files)

@ssnl
Copy link
Collaborator Author

ssnl commented Jul 1, 2020

@ezyang seems working now! :)

facebook-github-bot
facebook-github-bot reviewed Jul 4, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 4, 2020

@ezyang merged this pull request in 0790d11.

@ssnl ssnl mentioned this pull request Jul 8, 2020
Closed
@ssnl ssnl deleted the SsnL-patch-10 branch July 8, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[typing] tensor.T is not typed

6 participants

@ssnl @ezyang @facebook-github-bot @pytorchbot @mruberry