Skip to content

fix issue #31759 (allow valid ASCII python identifiers as dimnames) #40871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
teichert wants to merge 2 commits into from
Closed

fix issue #31759 (allow valid ASCII python identifiers as dimnames) #40871

teichert wants to merge 2 commits into from

Conversation

@teichert
Copy link
Contributor

@teichert teichert commented Jul 1, 2020

Fixes issue #31759:

  • Changes is_valid_identifier check on named tensor dimensions to allow digits if they are not at the beginning of the name (this allows exactly the ASCII subset of valid python identifiers).
  • Updates error message for illegal dimension names.
  • Updates and adds relevant tests.

@teichert
allowing valid ascii python identifiers as dimnames (i.e. allowing di…
58b6ebc 
…gits as long as they are not at the beginning)
@teichert teichert marked this pull request as ready for review July 1, 2020 21:51
@teichert
Copy link
Contributor Author

teichert commented Jul 1, 2020

@ezyang or @zou3519 would you mind reviewing this?

zou3519
zou3519 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

facebook-github-bot
facebook-github-bot reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@teichert teichert deleted the fix_issue_31759_allow_digits_in_dimnames branch July 2, 2020 21:04
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 2, 2020

@zou3519 merged this pull request in 6aabd12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@teichert @facebook-github-bot @zou3519 @pytorchbot @mruberry