[JIT] Add support for backend-lowered submodules #40841
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. [ghstack-poisoned]
This was referenced Jul 1, 2020
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 4f1c381 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 10 times. |
added 3 commits
July 2, 2020 15:43
**Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. [ghstack-poisoned]
**Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. [ghstack-poisoned]
**Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. [ghstack-poisoned]
suo
reviewed
Jul 6, 2020
| self.test_execution() | ||
|
|
||
|
|
||
| class NestedModuleTest(JitBackendTestCase): |
Member
There was a problem hiding this comment.
It's kind of hard to read this test because NestedModule and MyModule are defined at the top of this file. Generally we define any necessary test-specific fixtures inside the body of a test so that things stay local.
Author
There was a problem hiding this comment.
It's hard to nest MyModule because this test and the other test both use it. I can nest NestedModule though.
| // This is a helper function for creating a new instance of the | ||
| // backend class. | ||
| static const auto create_backend_ct = CodeTemplate(R"( | ||
| auto codegen_lambda = [=](const std::string& backend_name, |
Member
There was a problem hiding this comment.
Mind commenting on what the meaningful change here is? I think the indentation shift made GH freak out
Author
There was a problem hiding this comment.
I wrapped all the codegen in a lambda so I could do:
return wrap_cpp_module(codegen_lambda(args)));
instead of
return wrap_cpp_module([](...){
// lots
// of
// code
});
**Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. [ghstack-poisoned]
Contributor
|
@SplitInfinity merged this pull request in 6777ea1. |
SplitInfinity
pushed a commit
that referenced
this pull request
Jul 8, 2020
Summary: Pull Request resolved: #40841 **Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. ghstack-source-id: b6aabcf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
This commit adds support for using
Modulesthat have been lowered assubmodules in
ScriptModules.Test Plan
This commit adds execution and save/load tests to test_backends.py for
backend-lowered submodules.
Fixes
This commit fixes #40069.
Differential Revision: D22418716