[JIT] Separate to_backend API into libtorch and libtorch_python #40839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** This commit splits the to_backend API properly into `libtorch` and `libtorch_python`. The backend interface and all of the code needed to run a graph on a backend is in libtorch, and all of the code related to creating a Python binding for the lowering process is in `libtorch_python`. **Test Plan** `python test/test_jit.py TestBackends` **Fixes** This commit fixes #40072. [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
This was referenced Jul 1, 2020
💊 CI failures summary and remediationsAs of commit 106c16a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 12 times. |
added 3 commits
July 2, 2020 15:43
…ython" **Summary** This commit splits the to_backend API properly into `libtorch` and `libtorch_python`. The backend interface and all of the code needed to run a graph on a backend is in libtorch, and all of the code related to creating a Python binding for the lowering process is in `libtorch_python`. **Test Plan** `python test/test_jit.py TestBackends` **Fixes** This commit fixes #40072. [ghstack-poisoned]
…ython" **Summary** This commit splits the to_backend API properly into `libtorch` and `libtorch_python`. The backend interface and all of the code needed to run a graph on a backend is in libtorch, and all of the code related to creating a Python binding for the lowering process is in `libtorch_python`. **Test Plan** `python test/test_jit.py TestBackends` **Fixes** This commit fixes #40072. [ghstack-poisoned]
…ython" **Summary** This commit splits the to_backend API properly into `libtorch` and `libtorch_python`. The backend interface and all of the code needed to run a graph on a backend is in libtorch, and all of the code related to creating a Python binding for the lowering process is in `libtorch_python`. **Test Plan** `python test/test_jit.py TestBackends` **Fixes** This commit fixes #40072. [ghstack-poisoned]
suo
approved these changes
Jul 6, 2020
…ython" **Summary** This commit splits the to_backend API properly into `libtorch` and `libtorch_python`. The backend interface and all of the code needed to run a graph on a backend is in libtorch, and all of the code related to creating a Python binding for the lowering process is in `libtorch_python`. **Test Plan** `python test/test_jit.py TestBackends` **Fixes** This commit fixes #40072. [ghstack-poisoned]
Contributor
|
@SplitInfinity merged this pull request in 3e01931. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
This commit splits the to_backend API properly into
libtorchandlibtorch_python. The backend interface and allof the code needed to run a graph on a backend is in
libtorch, and all of the code related to creating a Python binding
for the lowering process is in
libtorch_python.Test Plan
python test/test_jit.py TestBackendsFixes
This commit fixes #40072.
Differential Revision: D22418664