Fix the autograd codegen for repeat function #40766
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Before adding the special case, struct TORCH_API RepeatBackward : public TraceableFunction {
using TraceableFunction::TraceableFunction;
variable_list apply(variable_list&& grads) override;
std::string name() const override { return "RepeatBackward"; }
void release_variables() override {
std::lock_guard<std::mutex> lock(mutex_);
self_.reset_data();
self_.reset_grad_function();
}
SavedVariable self_;
std::vector<int64_t> repeats;
};With the special case added, the struct looks like below: struct TORCH_API RepeatBackward : public TraceableFunction {
using TraceableFunction::TraceableFunction;
variable_list apply(variable_list&& grads) override;
std::string name() const override { return "RepeatBackward"; }
void release_variables() override {
}
int64_t self_dim = 0;
std::vector<int64_t> repeats;
};please kind review this PR @albanD |
albanD
added
the
triaged
albanD
approved these changes
Jun 30, 2020
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Wow I wasn't expecting this to be so simple :)
Thanks for taking the time to make the PR!
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@albanD is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40701
A new special case is added to let
dim()save an int instead of self.