[TB] Add support for hparam domain_discrete #40720
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add support for populating domain_discrete field in TensorBoard add_hparams API Test Plan: Unit test test_hparams_domain_discrete Differential Revision: D22291347 fbshipit-source-id: 98a9ff203ead40e555dab8af7dc2d47df312402b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D22291347 |
edward-io
reviewed
Jun 29, 2020
| mt = {"accuracy": 0.1} | ||
| hp_domain = {"lr": [0.1], "bool_var": [True], "string_var": ["hi"]} | ||
| # only smoke test. Because protobuf map serialization is nondeterministic. | ||
| summary.hparams(hp, mt, hp_domain) |
Contributor
There was a problem hiding this comment.
can you construct the expected proto separately and compare it to whats expected from summary.hparams?
Contributor
|
This pull request has been merged in 01e2099. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add support for populating domain_discrete field in TensorBoard add_hparams API
Test Plan: Unit test test_hparams_domain_discrete
Differential Revision: D22291347