[quant] aten::repeat work for quantized tensor #40644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
reviewed
Jun 26, 2020
| if (self.is_quantized()) { | ||
| result = at::empty_quantized(target_size, self); | ||
| } else { | ||
| result = at::empty(target_size, self.options()); |
Contributor
There was a problem hiding this comment.
does dispatching on tensor type not work for at::empty?
Contributor
Author
There was a problem hiding this comment.
yeah, quantized parameters are not included in TensorOptions(self.options())
vkuzo
approved these changes
Jun 26, 2020
supriyar
reviewed
Jun 26, 2020
| variants: method | ||
| device_guard: False | ||
|
|
||
| - func: empty_quantized(int[] size, Tensor original) -> Tensor |
Contributor
There was a problem hiding this comment.
The name seems a little non-intuitive to me. Maybe make it explicit that original has to be a quantized tensor.
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22268558](https://our.internmc.facebook.com/intern/diff/D22268558) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22268558](https://our.internmc.facebook.com/intern/diff/D22268558) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22268558](https://our.internmc.facebook.com/intern/diff/D22268558) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 84ad128 (more details on the Dr. CI page):
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 4 times. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22268558](https://our.internmc.facebook.com/intern/diff/D22268558) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 61a8de7. |
jerryzh168
added a commit
that referenced
this pull request
Jun 29, 2020
Summary: Pull Request resolved: #40644 Test Plan: Imported from OSS Differential Revision: D22268558 fbshipit-source-id: 3bc9a129bece1b547c519772ecc6b980780fb904
jerryzh168
added a commit
that referenced
this pull request
Jul 2, 2020
Summary: Pull Request resolved: #40644 Test Plan: Imported from OSS Differential Revision: D22268558 fbshipit-source-id: 3bc9a129bece1b547c519772ecc6b980780fb904
jerryzh168
added a commit
that referenced
this pull request
Jul 3, 2020
Summary: Pull Request resolved: #40644 Test Plan: Imported from OSS Differential Revision: D22268558 fbshipit-source-id: 3bc9a129bece1b547c519772ecc6b980780fb904
malfet
pushed a commit
that referenced
this pull request
Jul 7, 2020
* [quant] aten::repeat work for quantized tensor (#40644) Summary: Pull Request resolved: #40644 Test Plan: Imported from OSS Differential Revision: D22268558 fbshipit-source-id: 3bc9a129bece1b547c519772ecc6b980780fb904 * [quant][graphmode][fix] remove unsupported ops in the list (#40653) Summary: Pull Request resolved: #40653 (Note: this ignores all push blocking failures!) Test Plan: Imported from OSS Differential Revision: D22271413 fbshipit-source-id: a01611b5d90849ac673fa5a310f910c858e907a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D22268558