-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Add PyTorch Glossary #40639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyTorch Glossary #40639
Conversation
SplitInfinity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that these terms pertain to a specific part of PyTorch (that I personally haven't had to touch). Maybe we should break this down into sections? E.g. core, distributed, JIT, etc.
In addition, I wonder if there are better tools or formats to use for this. I guess people can Ctrl + F but I think everyone expects glossaries to be sorted alphabetically, and that is something that will be tedious to do by hand.
GLOSSARY.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| An Operations that is defined by users and are usually Compound Operations. | |
| An Operation that is defined by users and is usually a Compound Operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
GLOSSARY.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| used. | |
| uses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Good point. I am not aware of better tools to use for this, maybe github wiki? But then it would not be very visible for fb internal. Anyway, I added a table of content, vscode actually has an extension that can automatically update table of content upon file save, so that should help with indexing and alleviate the burden of maintenance. |
|
Gentle ping. |
suo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
on the "should this be a wiki" issue—I think we can just commit in the repo for now and see what happens |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@gmagogsfm merged this pull request in 445128d. |
No description provided.