[quant][graphmode][fix] cloning schema in insert_observers #40624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously we didn't clone schema, so the default schema is used, this is causing issue for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 85541a3 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 14 times. |
Summary: Previously we didn't clone schema, so the default schema is used, this is causing issue for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22259519](https://our.internmc.facebook.com/intern/diff/D22259519) [ghstack-poisoned]
vkuzo
approved these changes
Jun 26, 2020
Contributor
vkuzo
left a comment
vkuzo
left a comment
There was a problem hiding this comment.
makes sense. What was the error, just for own learning?
Contributor
Author
forward function with default args failed to run after insert observers, I guess this info is probably in the schema. btw, please take a look at the next PR as well, that is a fix for another model. |
Summary: Previously we didn't clone schema, so the default schema is used, this is causing issue for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22259519](https://our.internmc.facebook.com/intern/diff/D22259519) [ghstack-poisoned]
Summary: Previously we didn't clone schema, so the default schema is used, this is causing issue for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22259519](https://our.internmc.facebook.com/intern/diff/D22259519) [ghstack-poisoned]
Summary: Previously we didn't clone schema, so the default schema is used, this is causing issue for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22259519](https://our.internmc.facebook.com/intern/diff/D22259519) [ghstack-poisoned]
Summary: Previously we didn't clone schema, so the default schema is used, this is causing issue for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22259519](https://our.internmc.facebook.com/intern/diff/D22259519) [ghstack-poisoned]
Summary: Previously we didn't clone schema, so the default schema is used, this is causing issue for some models Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22259519](https://our.internmc.facebook.com/intern/diff/D22259519) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 0309f6a. |
jerryzh168
added a commit
that referenced
this pull request
Jun 29, 2020
Summary: Pull Request resolved: #40624 Previously we didn't clone schema, so the default schema is used, this is causing issue for some models Test Plan: Imported from OSS Differential Revision: D22259519 fbshipit-source-id: e2a393a54cb18f55da0c7152a74ddc22079ac350
jerryzh168
added a commit
that referenced
this pull request
Jul 2, 2020
Summary: Pull Request resolved: #40624 Previously we didn't clone schema, so the default schema is used, this is causing issue for some models Test Plan: Imported from OSS Differential Revision: D22259519 fbshipit-source-id: e2a393a54cb18f55da0c7152a74ddc22079ac350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Previously we didn't clone schema, so the default schema is used, this is
causing issue for some models
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D22259519