[NCCL - reland] Explicitly abort NCCL Communicators on Process Group Destruction #40585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Destruction This PR aborts incomplete NCCL Communicators in the ProcessGroupNCCL destructor. This should prevent pending NCCL communicators from blocking other CUDA ops. Differential Revision: [D22244873](https://our.internmc.facebook.com/intern/diff/D22244873/) [ghstack-poisoned]
osalpekar
requested review from
mrshenli,
pietern and
zhaojuanmao
as code owners
osalpekar
added a commit
that referenced
this pull request
Jun 25, 2020
…Destruction This PR aborts incomplete NCCL Communicators in the ProcessGroupNCCL destructor. This should prevent pending NCCL communicators from blocking other CUDA ops. Differential Revision: [D22244873](https://our.internmc.facebook.com/intern/diff/D22244873/) ghstack-source-id: 106633077 Pull Request resolved: #40585
mrshenli
approved these changes
Jun 25, 2020
agolynski
approved these changes
Jun 25, 2020
agolynski
approved these changes
Jun 25, 2020
jiayisuse
approved these changes
Jun 26, 2020
…cess Group Destruction" This PR aborts incomplete NCCL Communicators in the ProcessGroupNCCL destructor. This should prevent pending NCCL communicators from blocking other CUDA ops. Differential Revision: [D22244873](https://our.internmc.facebook.com/intern/diff/D22244873/) [ghstack-poisoned]
osalpekar
added a commit
that referenced
this pull request
Jul 1, 2020
…Destruction Pull Request resolved: #40585 This PR aborts incomplete NCCL Communicators in the ProcessGroupNCCL destructor. This should prevent pending NCCL communicators from blocking other CUDA ops. ghstack-source-id: 106988073 Differential Revision: [D22244873](https://our.internmc.facebook.com/intern/diff/D22244873/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D22244873/)!
💊 CI failures summary and remediationsAs of commit c937cab (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
Contributor
|
This pull request has been merged in 49e12d8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR aborts incomplete NCCL Communicators in the ProcessGroupNCCL
destructor. This should prevent pending NCCL communicators from blocking other CUDA ops.
Differential Revision: D22244873