[android][readme] Aar native linking add fbjni #40578
Conversation
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 6d3a7b3 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
| PATHS ${PYTORCH_LINK_DIRS} | ||
| NO_CMAKE_FIND_ROOT_PATH) | ||
| find_library(FBJNI_LIBRARY fbjni |
There was a problem hiding this comment.
Not in this PR: have you thought about providing a cmake file for client project to import useful library variables without manually creating/maintaining them?
I've seen this pattern for some OSS library, including PyTorch itself. Here is the public cmake file we generate: https://github.com/pytorch/pytorch/blob/master/cmake/TorchConfig.cmake.in
And in client project's cmake it can use find_package to locate the library's cmake and obtain $TORCH_INCLUDE_DIRS and $TORCH_LIBRARIES variables directly: https://github.com/pytorch/pytorch/blob/master/test/mobile/custom_build/CMakeLists.txt#L8
In this specific example, we don't need to maintain the dozen of static libraries as we do elsewhere: https://github.com/pytorch/pytorch/blob/master/android/pytorch_android/CMakeLists.txt#L96-L105
Just an idea - not sure if it's appropriate/common for native android projects.
There was a problem hiding this comment.
Thanks. This is a good idea, I will try to create cmake config files, to use just find_package on client side
|
@IvanKobzarev merged this pull request in a0569ad. |
Stack from ghstack:
Differential Revision: D22239286
libpytorch_jni.so is dynamically linked with libfbjni.so, if to link to it - we need libfbjni.so as well - adding it to the readme with cmake setup for that linking