Skip to content

relax size check in flatten_for_scatter_gather #40573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ngimel wants to merge 1 commit into from
Closed

relax size check in flatten_for_scatter_gather #40573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions torch/lib/c10d/ProcessGroupNCCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,13 +624,9 @@ std::vector<at::Tensor> flatten_for_scatter_gather(
}

for (const auto& t : tensor_lists[i]) {
if (t.sizes() != other[i].sizes()) {
if (t.numel() != other[i].numel()) {
throw std::runtime_error(
"All tensor operands to scatter/gather must have the same size");
}
if (t.strides() != other[i].strides()) {
throw std::runtime_error(
"All tensor operands to scatter/gather must have the same layout (strides)");
"All tensor operands to scatter/gather must have the same number of elements");
}
}
// Flatten the tensors (from all ranks) into a single big tensor.
Expand Down