relax size check in flatten_for_scatter_gather #40573
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D22236942 |
mcarilli
approved these changes
Jun 25, 2020
torch/lib/c10d/ProcessGroupNCCL.cpp
Outdated
Collaborator
There was a problem hiding this comment.
Suggestion, which you can take or leave: change "the same" to "identical"...not because it's better phrasing, but so that when people ping us with an error message, we know immediately they're using this version of the check.
Summary: Pull Request resolved: pytorch#40573 Per title, to workaround apex sbn bug. Test Plan: Covered by existing tests Reviewed By: blefaudeux Differential Revision: D22236942 fbshipit-source-id: 4e195e35e3e1b309400be53614d5368f6c08801e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D22236942 |
💊 CI failures summary and remediationsAs of commit 74b7f1f (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 2 times. |
Contributor
|
This pull request has been merged in b05c342. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Per title, to workaround apex sbn bug.
Test Plan: Covered by existing tests
Differential Revision: D22236942