Skip to content

[ONNX] Add warning in ONNX export when constant folding is on in training-amenable mode #40546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spandantiwari wants to merge 2 commits into from
Closed

[ONNX] Add warning in ONNX export when constant folding is on in training-amenable mode #40546

spandantiwari wants to merge 2 commits into from

Conversation

@spandantiwari
Copy link

@spandantiwari spandantiwari commented Jun 25, 2020

This PR introduces a warning when user tries to export the model to ONNX in training-amenable mode while constant folding is turned on. We want to warn against any unintentional use because constant folding may fold some parameters that may be intended to be trainable in the exported model.

@spandantiwari spandantiwari requested a review from houseroad June 25, 2020 01:14
@spandantiwari spandantiwari changed the title Add warning in ONNX export when constant folding is on in training-amenable mode [ONNX] Add warning in ONNX export when constant folding is on in training-amenable mode Jun 25, 2020
@dr-ci
Copy link

dr-ci bot commented Jun 25, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit fef706b (more details on the Dr. CI page):

  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 1/2 broken upstream at merge base 9a3e16c on Jun 24 from 10:20am to 5:16pm PDT (23 commits; 597cb04 - e12f73e)

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 10 times.

@spandantiwari
Copy link
Author

spandantiwari commented Jun 25, 2020

Updated one more call site to fix test failures.

@spandantiwari
Copy link
Author

spandantiwari commented Jun 25, 2020

The build failures seem unrelated. All tests are passing.

@zhangguanheng66 zhangguanheng66 added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 25, 2020
@spandantiwari
Copy link
Author

spandantiwari commented Jun 29, 2020

@houseroad - could you please take a look when you get a chance. Thanks.

facebook-github-bot
facebook-github-bot reviewed Jun 30, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 2, 2020

@houseroad merged this pull request in ea03f95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

Assignees

No one assigned

Labels

Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@spandantiwari @facebook-github-bot @houseroad @zhangguanheng66 @pytorchbot @mruberry