Add __all__ to torch/_C/_VariableFunctions.pyi #40499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a template variable that contains the names of the typed functions and the named tuples during .pyi generation, appending it as the `__all__` attribute of `_VariableFunctions.pyi`.
gchanan
added
the
triaged
Contributor
|
Can you paste the generated output? Looks good! |
ezyang
approved these changes
Jun 25, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Contributor
Author
Probably a bit late, but for reference, this is the bit that gets appended to the bottom of __all__ = ['__and__', '__lshift__', '__or__', '__rshift__', '__xor__', '_adaptive_avg_pool2d', '_addmv_impl_',
'_addr', '_addr_', '_amp_non_finite_check_and_unscale_', '_amp_update_scale', '_baddbmm_mkl_',
...
'true_divide', 'trunc', 'trunc_', 'unbind', 'unique_dim', 'unsqueeze', 'vander', 'var', 'var_mean',
'view_as_complex', 'view_as_real', 'where', 'zero_', 'zeros', 'zeros_like'] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #40397
Summary
Inspired by ezyang's comment at #40397 (comment), this PR attempts to leverage using
__all__to explicitly export private functions from_VariableFunctions.pyiin order to makemypyaware of them after:The generation of the
__all__template variable excludes some items fromunsorted_function_hints, as it seems that those without hints end up not being explicitly included in the.pyifile: I leaned on the side of caution and opted for having__all__consistent with the definitions inside the file. Additionally, added some pretty-printing to avoid having an extremely long line.