Skip to content

ONNX: support view_as operator #40496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yaeldekel wants to merge 1 commit into from
Closed

ONNX: support view_as operator #40496

yaeldekel wants to merge 1 commit into from

Conversation

@yaeldekel
Copy link

@yaeldekel yaeldekel commented Jun 24, 2020

This PR adds support for the torch view_as operator.

@dr-ci
Copy link

dr-ci bot commented Jun 24, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit d67e1ec (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test2 (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

AssertionError: False is not true 
  test_mem_leak (__main__.TestProfiler_cuda) 
Checks that there's no memory leak when using profiler with CUDA ... FAIL (6.874s) 
 
====================================================================== 
FAIL [6.874s]: test_mem_leak (__main__.TestProfiler_cuda) 
Checks that there's no memory leak when using profiler with CUDA 
---------------------------------------------------------------------- 
Traceback (most recent call last): 
  File "test_profiler.py", line 42, in test_mem_leak 
    self.assertTrue(max_diff < 100 * 1024) 
AssertionError: False is not true 
 
---------------------------------------------------------------------- 
Ran 1 test in 6.874s 
 
FAILED (failures=1) 
 
Generating XML reports... 
Generated XML report: test-reports\python-unittest\TEST-TestProfiler_cuda-20200624105823.xml 
Traceback (most recent call last): 
  File "run_test.py", line 727, in <module>
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@gchanan gchanan requested a review from houseroad June 25, 2020 17:09
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 25, 2020
neginraoof
neginraoof approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@KsenijaS
Copy link
Contributor

KsenijaS commented Jun 26, 2020

looks good. LGTM!

@yaeldekel
Copy link
Author

yaeldekel commented Jun 30, 2020

cc @houseroad for review. Thanks!

houseroad
houseroad approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

facebook-github-bot
facebook-github-bot reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 7, 2020

@houseroad merged this pull request in 56396ad.

csarofeen pushed a commit to csarofeen/pytorch that referenced this pull request Jul 7, 2020
@yaeldMS @csarofeen
ONNX: support view_as operator (pytorch#40496)
bf9e22f 
Summary:
This PR adds support for the torch `view_as` operator.

Pull Request resolved: pytorch#40496

Reviewed By: hl475

Differential Revision: D22398318

Pulled By: houseroad

fbshipit-source-id: f92057f9067a201b707aa9b8fc4ad34643dd5fa3
csarofeen added a commit to csarofeen/pytorch that referenced this pull request Aug 16, 2020
@csarofeen
Revert "ONNX: support view_as operator (pytorch#40496)"
b64efae 
This reverts commit bf9e22f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

+1 more reviewer

@neginraoof neginraoof neginraoof approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@yaeldekel @KsenijaS @facebook-github-bot @neginraoof @houseroad @gchanan @pytorchbot @mruberry @yaeldMS