Skip to content

Use Int8QuantParamsBlob to pass the scale and zeropoint params #40494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csummersea wants to merge 1 commit into from
Closed

Use Int8QuantParamsBlob to pass the scale and zeropoint params #40494

csummersea wants to merge 1 commit into from

Conversation

@csummersea
Copy link
Contributor

@csummersea csummersea commented Jun 24, 2020

Summary:
Resubmit the diff because D22124313 (1ec4337) was reverted due to CI test failures
Added the int8_gen_quant_params.cc to CMakeList.txt to fix the CI failures

Test Plan: buck test caffe2/caffe2/quantization/server:

Differential Revision: D22204244

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2020

This pull request was exported from Phabricator. Differential Revision: D22204244

@csummersea @facebook-github-bot
Use Int8QuantParamsBlob to pass the scale and zeropoint params (pytor…
91e89c6 
…ch#40494)

Summary:
Pull Request resolved: pytorch#40494

Resubmit the diff because D22124313 (pytorch@1ec4337) was reverted due to CI test failures
Added the int8_gen_quant_params.cc to CMakeList.txt to fix the CI failures

Test Plan: buck test caffe2/caffe2/quantization/server:

Differential Revision: D22204244

fbshipit-source-id: ff4668f6aaa573ada76d053b8b8cdcafa5f50aa9
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2020

This pull request was exported from Phabricator. Differential Revision: D22204244

@dr-ci
Copy link

dr-ci bot commented Jun 24, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 91e89c6 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_bazel_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jun 24 06:42:39 Executed 0 out of 25 tests: 1 fails to build and FAILED: Build did NOT complete successfully 
Jun 24 06:42:39 //:optim_test                                                         NO STATUS 
Jun 24 06:42:39 //:ordered_dict_test                                                  NO STATUS 
Jun 24 06:42:39 //:sequential_test                                                    NO STATUS 
Jun 24 06:42:39 //:serialize_test                                                     NO STATUS 
Jun 24 06:42:39 //:static_test                                                        NO STATUS 
Jun 24 06:42:39 //:tensor_options_test                                                NO STATUS 
Jun 24 06:42:39 //:tensor_test                                                        NO STATUS 
Jun 24 06:42:39 //:torch_include_test                                                 NO STATUS 
Jun 24 06:42:39 //:rnn_test                                                     FAILED TO BUILD 
Jun 24 06:42:39  
Jun 24 06:42:39 Executed 0 out of 25 tests: 1 fails to build and FAILED: Build did NOT complete successfully 
Jun 24 06:42:39 24 were skipped. 
Jun 24 06:42:39 + cleanup 
Jun 24 06:42:39 + retcode=1 
Jun 24 06:42:39 + set +x 
Jun 24 06:42:39 =================== sccache compilation log =================== 
Jun 24 06:42:39 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Jun 24 06:42:39 Compile requests               139 
Jun 24 06:42:39 Compile requests executed      109 
Jun 24 06:42:39 Cache hits                     109 
Jun 24 06:42:39 Cache misses                     0
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2020

This pull request has been merged in 597cb04.

malfet added a commit to malfet/pytorch that referenced this pull request Jun 24, 2020
@malfet
Add missing file to BUILD.bazel
06b080d 
Add `int8_gen_quant_params.cc` added by
pytorch#40494 to bazel build rules
@malfet malfet mentioned this pull request Jun 24, 2020
Closed
facebook-github-bot pushed a commit that referenced this pull request Jun 25, 2020
@malfet @facebook-github-bot
Add missing file to BUILD.bazel (#40536)
e12f73e 
Summary:
Add `int8_gen_quant_params.cc` added by
#40494 to bazel build rules
Pull Request resolved: #40536

Reviewed By: mruberry

Differential Revision: D22219595

Pulled By: malfet

fbshipit-source-id: 2875a0b9c55bad2b052a898661b96eab490f6451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csummersea @facebook-github-bot @mruberry