Add C++-only int dim overloads to std-related operations
#40451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The int->bool conversion taking higher precedence than int->IntArrayRef. So, calling std(0) in c++ wouldn't select the dimension overload.
peterbell10
requested review from
ebetica,
goldsborough and
yf225
as code owners
💊 CI failures summary and remediationsAs of commit 2ad750c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
zou3519
reviewed
Jun 23, 2020
| return at::native::var(self, IntArrayRef{dim}); | ||
| } | ||
|
|
||
| inline std::tuple<Tensor,Tensor> var_mean(const Tensor& self, int dim) { |
Collaborator
Author
There was a problem hiding this comment.
std(0) will only work if the type is an exact match for operator overloading, so dim must be exactly int. I could add more overloads to accept other integral types, but an int overload would still be needed.
Contributor
There was a problem hiding this comment.
Would be good to explicitly mention this in the comment!
zou3519
added
the
triaged
ezyang
approved these changes
Jun 24, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-40287
The
int -> boolconversion takes higher precedence thanint -> IntArrayRef. So, callingstd(0)in C++ would select thestd(unbiased=False)overload instead.