Skip to content

Doc fix for complex views #40450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anjali411 wants to merge 2 commits into from
Closed

Doc fix for complex views #40450

anjali411 wants to merge 2 commits into from

Conversation

@anjali411
Copy link
Contributor

@anjali411 anjali411 commented Jun 23, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D22190911

@anjali411
Doc fix for complex views
a4c4020 
[ghstack-poisoned]
@anjali411 anjali411 requested a review from mruberry June 23, 2020 18:34
@mruberry
Copy link
Collaborator

mruberry commented Jun 23, 2020

Lint issues are real, clang-tidy failure is not.

anjali411 added a commit that referenced this pull request Jun 23, 2020
@anjali411
Doc fix for complex views
8aeac09 
ghstack-source-id: 2e798b6
Pull Request resolved: #40450
@dr-ci
Copy link

dr-ci bot commented Jun 23, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit e728ffd (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build caffe2_onnx_ort1_py3_6_clang7_ubuntu16_04_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_squeezenet FAILED [ 16%] 
Jun 23 19:25:49 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_rsqrt PASSED [ 15%] 
Jun 23 19:25:49 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_rsub PASSED [ 15%] 
Jun 23 19:25:49 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_scalar_type PASSED [ 15%] 
Jun 23 19:25:49 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_scatter PASSED [ 15%] 
Jun 23 19:25:49 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_select PASSED [ 16%] 
Jun 23 19:25:49 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_size PASSED [ 16%] 
Jun 23 19:25:49 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_softmax PASSED [ 16%] 
Jun 23 19:25:49 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_softmax_dtype PASSED [ 16%] 
Jun 23 19:25:49 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_sqrt PASSED [ 16%] 
Jun 23 19:25:49 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_squeeze PASSED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_squeezenet FAILED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_srresnet SKIPPED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_std PASSED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_std_along_dims PASSED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_subconstant PASSED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_sum PASSED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_super_resolution SKIPPED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_tensor_factories PASSED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_tensor_factories_script PASSED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_tensor_index_1d PASSED [ 16%] 
Jun 23 19:28:01 test/onnx/test_pytorch_onnx_caffe2.py::TestCaffe2BackendEmbed_opset9::test_tensor_index_2d_1dconstant PASSED [ 16%]
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@anjali411
Copy link
Contributor Author

anjali411 commented Jun 23, 2020

Lint issues are real, clang-tidy failure is not.

yeah fixed it :D

mruberry
mruberry approved these changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped!

@vadimkantorov
Copy link
Contributor

vadimkantorov commented Jun 23, 2020 •
edited
Loading

One late naming suggestion: torch.as_complex / torch.as_real similar to torch.as_tensor (which also does not copy memory by default) @anjali411

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2020

@anjali411 merged this pull request in 0928507.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2020

@anjali411 merged this pull request in 0928507.

@facebook-github-bot facebook-github-bot deleted the gh/anjali411/36/head branch June 27, 2020 14:16
@anjali411 anjali411 mentioned this pull request Jun 30, 2020
Closed
malfet pushed a commit that referenced this pull request Jun 30, 2020
@anjali411 @malfet
[1.6 cherrypick] Doc fix for complex views
dede34e 
Cherry-pick of #40450

Test Plan: Imported from OSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anjali411 @mruberry @vadimkantorov @facebook-github-bot