Skip to content

[CUDA] addmm for complex #40431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anjali411 wants to merge 7 commits into from
Closed

[CUDA] addmm for complex #40431

anjali411 wants to merge 7 commits into from

Conversation

@anjali411
Copy link
Contributor

@anjali411 anjali411 commented Jun 23, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D22285916

@anjali411
[CUDA] addmm for complex
50a49bd 
[ghstack-poisoned]
anjali411 added a commit that referenced this pull request Jun 23, 2020
@anjali411
[CUDA] addmm for complex
b170219 
ghstack-source-id: 99556bc
Pull Request resolved: #40431
@dr-ci
Copy link

dr-ci bot commented Jun 23, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit ac2c9b0 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 15 times.

anjali411 added a commit that referenced this pull request Jun 23, 2020
@anjali411
[CUDA] addmm for complex
58412ca 
ghstack-source-id: 7525365
Pull Request resolved: #40431
ezyang
ezyang requested changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine, but you're going to have to handle ROCm differently. I'd probably just suggest putting in stub specializations that raise an error, instead of ifdefing it all out. I'm wrong! Just skip the tests

anjali411 added a commit that referenced this pull request Jun 26, 2020
@anjali411
[CUDA] addmm for complex
a50d431 
ghstack-source-id: a22798b
Pull Request resolved: #40431
@anjali411 anjali411 requested a review from ezyang June 26, 2020 18:05
anjali411 added a commit that referenced this pull request Jun 29, 2020
@anjali411
[CUDA] addmm for complex
b129ed4 
ghstack-source-id: d824ece
Pull Request resolved: #40431
anjali411 added a commit that referenced this pull request Jun 29, 2020
@anjali411
[CUDA] addmm for complex
4dfe7d7 
ghstack-source-id: 05d9af9
Pull Request resolved: #40431
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 30, 2020

@anjali411 merged this pull request in 9393ac0.

@facebook-github-bot facebook-github-bot deleted the gh/anjali411/35/head branch July 3, 2020 14:16
@anjali411 anjali411 mentioned this pull request Jul 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@zasdfgbnm zasdfgbnm Awaiting requested review from zasdfgbnm

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anjali411 @facebook-github-bot @ezyang @mruberry