Skip to content

[quant] ConvTranspose1d / ConvTranspose2d #40371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
z-a-f wants to merge 32 commits into from
Closed

[quant] ConvTranspose1d / ConvTranspose2d #40371

z-a-f wants to merge 32 commits into from

Conversation

@z-a-f
Copy link

@z-a-f z-a-f commented Jun 22, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D22158981

@z-a-f z-a-f requested a review from apaszke as a code owner June 22, 2020 09:24
This was referenced Jun 22, 2020
Closed
Closed
Closed
Closed
Closed
z-a-f pushed a commit that referenced this pull request Jun 22, 2020
[quant] ConvTranspose1d / ConvTranspose2d
a5207aa 
ghstack-source-id: 5a3a679
Pull Request resolved: #40371
@dr-ci
Copy link

dr-ci bot commented Jun 22, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 210b822 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Sep 13 02:31:28 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
Sep 13 02:31:28 processing existing schema:  add_constant(__torch__.torch.classes._TorchScriptTesting._ElementwiseInterpreter _0, str _1, Tensor _2) -> (None _0) 
Sep 13 02:31:28 processing existing schema:  set_input_names(__torch__.torch.classes._TorchScriptTesting._ElementwiseInterpreter _0, str[] _1) -> (None _0) 
Sep 13 02:31:28 processing existing schema:  set_output_name(__torch__.torch.classes._TorchScriptTesting._ElementwiseInterpreter _0, str _1) -> (None _0) 
Sep 13 02:31:28 processing existing schema:  __call__(__torch__.torch.classes._TorchScriptTesting._ElementwiseInterpreter _0, Tensor[] _1) -> (Tensor _0) 
Sep 13 02:31:28 processing existing schema:  __getstate__(__torch__.torch.classes._TorchScriptTesting._ElementwiseInterpreter _0) -> ((str[], str?, Dict(str, Tensor), (str, str[], str)[]) _0) 
Sep 13 02:31:28 processing existing schema:  __setstate__(__torch__.torch.classes._TorchScriptTesting._ElementwiseInterpreter _0, (str[], str?, Dict(str, Tensor), (str, str[], str)[]) _1) -> (None _0) 
Sep 13 02:31:28 processing existing schema:  get(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0, Tensor _1) -> (str _0) 
Sep 13 02:31:28 processing existing schema:  __getstate__(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0) -> (int _0) 
Sep 13 02:31:28 processing existing schema:  __setstate__(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0, int _1) -> (None _0) 
Sep 13 02:31:28 processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (None _0) 
Sep 13 02:31:28 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
Sep 13 02:31:28  
Sep 13 02:31:28 Broken ops: [ 
m2=0.5, float? n2=0, float? m3=0.5, float? start_warmup_multiplier=0.10000000000000001, int? constant_warmup_num_iter=10000000, int? linear_warmup_num_iter=10000000, float? cyclical_max_lr=0.050000000000000003, int? cyclical_step_size=1000000, float? cyclical_decay=0.999, float? cosine_min_lr=0.01, float? cosine_max_lr=0.050000000000000003, int? cosine_period=50, float? cosine_t_mult=1., float? cosine_lr_shrink=0.98999999999999999, Tensor[]? _caffe2_preallocated_outputs=None) -> (Tensor output) 
Sep 13 02:31:28 ] 
Sep 13 02:31:28 + cleanup 
Sep 13 02:31:28 + retcode=1 
Sep 13 02:31:28 + set +x 
Sep 13 02:31:28 =================== sccache compilation log =================== 
Sep 13 02:31:28 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Sep 13 02:31:28 Compile requests                 0
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 225 times.

z-a-f pushed a commit that referenced this pull request Jun 23, 2020
[quant] ConvTranspose1d / ConvTranspose2d
2bfe0f2 
ghstack-source-id: 2b5fb4a
Pull Request resolved: #40371
z-a-f pushed a commit that referenced this pull request Jun 26, 2020
[quant] ConvTranspose1d / ConvTranspose2d
ef8fcb1 
ghstack-source-id: bc5877a
Pull Request resolved: #40371
z-a-f pushed a commit that referenced this pull request Jun 28, 2020
[quant] ConvTranspose1d / ConvTranspose2d
364d627 
ghstack-source-id: 07afb51
Pull Request resolved: #40371
z-a-f pushed a commit that referenced this pull request Jun 30, 2020
[quant] ConvTranspose1d / ConvTranspose2d
0ca3bd9 
ghstack-source-id: 1cd0647
Pull Request resolved: #40371
z-a-f pushed a commit that referenced this pull request Jul 1, 2020
[quant] ConvTranspose1d / ConvTranspose2d
3e1372a 
ghstack-source-id: e7ca349
Pull Request resolved: #40371
z-a-f pushed a commit that referenced this pull request Jul 5, 2020
[quant] ConvTranspose1d / ConvTranspose2d
2980d4c 
ghstack-source-id: 9689062
Pull Request resolved: #40371
z-a-f pushed a commit that referenced this pull request Jul 12, 2020
[quant] ConvTranspose1d / ConvTranspose2d
0b1af37 
ghstack-source-id: a6e4a22
Pull Request resolved: #40371
z-a-f pushed a commit that referenced this pull request Jul 17, 2020
[quant] ConvTranspose1d / ConvTranspose2d
f7301c7 
ghstack-source-id: 6cc7d38
Pull Request resolved: #40371
z-a-f pushed a commit that referenced this pull request Jul 18, 2020
[quant] ConvTranspose1d / ConvTranspose2d
d09e632 
ghstack-source-id: 225dc96
Pull Request resolved: #40371
z-a-f pushed a commit that referenced this pull request Aug 18, 2020
[quant] ConvTranspose1d / ConvTranspose2d
d7163a0 
ghstack-source-id: 168ab36
Pull Request resolved: #40371
z-a-f pushed a commit that referenced this pull request Aug 18, 2020
[quant] ConvTranspose1d / ConvTranspose2d
0bb3535 
ghstack-source-id: 168ab36
Pull Request resolved: #40371
@z-a-f z-a-f mentioned this pull request Aug 18, 2020
Merged
@neuromorpheus
Copy link

neuromorpheus commented Aug 24, 2020

Hi,

When is this feature expected to be available in pytorch?

@z-a-f
Copy link
Author

z-a-f commented Aug 25, 2020

Hi,

When is this feature expected to be available in pytorch?

Hopefully soon. You mind I ask where you use it?

@neuromorpheus
Copy link

neuromorpheus commented Aug 27, 2020 via email

@z-a-f z-a-f requested a review from vkuzo September 3, 2020 00:45
vkuzo
vkuzo approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg as long as CI passes. Can we include the context and the test plan in the PR summary before landing, since this is non-trivial?

Zafar added 6 commits September 10, 2020 15:08
Update on "[quant] ConvTranspose1d / ConvTranspose2d"
eb33c1d 
Differential Revision: [D22158981](https://our.internmc.facebook.com/intern/diff/D22158981)

[ghstack-poisoned]
Update on "[quant] ConvTranspose1d / ConvTranspose2d"
f5b0968 
Differential Revision: [D22158981](https://our.internmc.facebook.com/intern/diff/D22158981)

[ghstack-poisoned]
Update on "[quant] ConvTranspose1d / ConvTranspose2d"
6f3e3d2 
Differential Revision: [D22158981](https://our.internmc.facebook.com/intern/diff/D22158981)

[ghstack-poisoned]
Update on "[quant] ConvTranspose1d / ConvTranspose2d"
f6cb2c3 
Differential Revision: [D22158981](https://our.internmc.facebook.com/intern/diff/D22158981)

[ghstack-poisoned]
Update on "[quant] ConvTranspose1d / ConvTranspose2d"
c9a8384 
Differential Revision: [D22158981](https://our.internmc.facebook.com/intern/diff/D22158981)

[ghstack-poisoned]
Update on "[quant] ConvTranspose1d / ConvTranspose2d"
210b822 
Differential Revision: [D22158981](https://our.internmc.facebook.com/intern/diff/D22158981)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 15, 2020

@z-a-f merged this pull request in 742654d.

@facebook-github-bot facebook-github-bot deleted the gh/z-a-f/42/head branch September 18, 2020 14:17
xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@xuzhao9
[quant] ConvTranspose1d / ConvTranspose2d (#40371)
9dcb91a 
Summary: Pull Request resolved: #40371

Test Plan: Imported from OSS

Reviewed By: vkuzo

Differential Revision: D22158981

Pulled By: z-a-f

fbshipit-source-id: defbf6fbe730a58d5b155dcb2460dd969797215c
@z-a-f z-a-f mentioned this pull request Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@paulshaoyuqiao paulshaoyuqiao Awaiting requested review from paulshaoyuqiao

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

@raghuramank100 raghuramank100 Awaiting requested review from raghuramank100

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@z-a-f @neuromorpheus @facebook-github-bot @vkuzo @kimishpatel @mruberry