-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Raise exception when trying to build PyTorch on 32-bit Windows system #40321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is this with reference to #27815 ? I thought the plan on record was just to disable this on Windows... |
|
@ezyang I can limit the check to just Windows, but can you think of any other 32-bit platform we might want to support? |
b1ad11f to
f3ac5e6
Compare
So we are rejecting users to build that by themselves, right? |
|
ezyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might suggest elaborating the error message a bit. The most common reason why bit size is 32 bit is because you have 32 bit Python, but your system might actually be 64 bit, in which case the correct fix is to install 64 bit Python (which is what was the case for the issue people filed.)
I think it will more useful if we patch the v0.1.2 source so that it will present better message if users try to install a binary package with 32-bit Python on Windows. |
f3ac5e6 to
89ba564
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit 89ba564 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Makes errors in cases described in #27815 more obvious