Skip to content

[doc] fix typo in formula of MarginRankingLoss #40285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NicolasHug wants to merge 1 commit into from
Closed

[doc] fix typo in formula of MarginRankingLoss #40285

NicolasHug wants to merge 1 commit into from

Conversation

@NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Jun 19, 2020

This is just a minor doc fix:

the MarginRankingLoss takes 2 input samples x1 and x2, not just x

@NicolasHug NicolasHug requested a review from apaszke as a code owner June 19, 2020 16:53
@dr-ci
Copy link

dr-ci bot commented Jun 19, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit d603f21 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-build-x86_32 (1/1)

Step: "pytorch android gradle build only x86_32 (for PR)" (full log | diagnosis details | 🔁 rerun)

Jun 19 17:47:06 CMake Error: The following variables are used in this project, but they are set to NOTFOUND. 
Jun 19 17:47:06 17:46:48.615 [INFO] [com.android.build.gradle.tasks.CmakeServerExternalNativeJsonGenerator] ]== "CMake Server" ==] 
Jun 19 17:47:06  
Jun 19 17:47:06 17:46:48.615 [INFO] [org.gradle.api.Project] External native JSON generation. mbqLocalBaseRelease|x86 : JSON generation for ABI: %s completed with problem. Exception: com.android.ide.common.process.ProcessException: Error configuring CMake server (/usr/local/bin).  
Jun 19 17:47:06 Check for working CXX compiler: /opt/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ 
Jun 19 17:47:06 Check for working CXX compiler: /opt/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ -- works 
Jun 19 17:47:06 Detecting CXX compiler ABI info 
Jun 19 17:47:06 Detecting CXX compiler ABI info - done 
Jun 19 17:47:06 Detecting CXX compile features 
Jun 19 17:47:06 Detecting CXX compile features - done 
Jun 19 17:47:06 ANDROID_STL:c++_shared 
Jun 19 17:47:06 CMake Error: The following variables are used in this project, but they are set to NOTFOUND. 
Jun 19 17:47:06 Please set them or make sure they are set and tested correctly in the CMake files: 
Jun 19 17:47:06 PYTORCH_LIBRARY 
Jun 19 17:47:06     linked by target "pytorch_testapp_jni" in directory /var/lib/jenkins/workspace/android/test_app/app 
Jun 19 17:47:06  
Jun 19 17:47:06 Configuring incomplete, errors occurred! 
Jun 19 17:47:06 See also "/var/lib/jenkins/workspace/android/test_app/app/.externalNativeBuild/cmake/mbqLocalBaseRelease/x86/CMakeFiles/CMakeOutput.log". 
Jun 19 17:47:06  
Jun 19 17:47:06 17:46:48.616 [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationExecutor] Completing Build operation 'Execute build for :test_app:generateJsonModelMbqLocalBaseRelease' 
Jun 19 17:47:06 17:46:48.616 [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationExecutor] Build operation 'Execute build for :test_app:generateJsonModelMbqLocalBaseRelease' completed 
Jun 19 17:47:06 17:46:48.616 [DEBUG] [org.gradle.api.internal.changedetection.state.CacheBackedTaskHistoryRepository] Fingerprinting property org.gradle.api.internal.tasks.NonCacheableTaskOutputPropertySpec@5c55684 for task ':test_app:generateJsonModelMbqLocalBaseRelease'
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

facebook-github-bot
facebook-github-bot reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2020

@zou3519 merged this pull request in a4dec06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@zou3519 zou3519 zou3519 approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NicolasHug @facebook-github-bot @zou3519 @pytorchbot @mruberry