Skip to content

Change function parameter self to input in torch.__init__.pyi #40235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MerHS wants to merge 3 commits into from
Closed

Change function parameter self to input in torch.__init__.pyi #40235

MerHS wants to merge 3 commits into from

Conversation

@MerHS
Copy link
Contributor

@MerHS MerHS commented Jun 18, 2020 •
edited
Loading

Fix #40223: Incorrect "self" keyword arguments in torch.__init__.pyi type hints

@dr-ci
Copy link

dr-ci bot commented Jun 18, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3187069 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 13 times.

@gchanan gchanan requested a review from ezyang June 25, 2020 17:07
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 25, 2020
@ezyang
Copy link
Contributor

ezyang commented Jun 25, 2020

tests failiures legit


Jun 18 19:55:39   test_doc_examples (__main__.TestTypeHints) ... /var/lib/jenkins/workspace/test/generated_type_hints_smoketest.py:1240: error: Argument 1 to "polygamma" has incompatible type "int"; expected "Tensor"
Jun 18 19:55:39 /var/lib/jenkins/workspace/test/generated_type_hints_smoketest.py:1240: error: Argument 2 to "polygamma" has incompatible type "Tensor"; expected "int"

@MerHS
Copy link
Contributor Author

MerHS commented Jun 26, 2020

@ezyang
Oh I see. It's because some torch functions (where, polygamma) have a self parameter other than the first place.
I've fixed it and it may run correctly now.

facebook-github-bot
facebook-github-bot reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 29, 2020

@ezyang merged this pull request in ed83b9a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect "self" keyword arguments in torch.__init__.pyi type hints

6 participants

@MerHS @ezyang @facebook-github-bot @gchanan @pytorchbot @mruberry