Fix linspace step computation for large integral types #40132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbelevich
approved these changes
Jun 17, 2020
Contributor
pbelevich
left a comment
pbelevich
left a comment
There was a problem hiding this comment.
Is it worth it to add a test for this case?
xuhdev
reviewed
Jun 17, 2020
Collaborator
xuhdev
left a comment
xuhdev
left a comment
There was a problem hiding this comment.
Could you also add a comment?
malfet
force-pushed
the
malfet/fix-linspace-step-computation
branch
from
3ddaa91 to
30a7ac4
Compare
💊 CI failures summary and remediationsAs of commit 9014baf (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 6 times. |
malfet
force-pushed
the
malfet/fix-linspace-step-computation
branch
from
30a7ac4 to
a2db92f
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Convert start and end to `step_t` before computing the difference Should fix `torch.linspace(-2147483647, 2147483647, 10, dtype=torch.int32)`
malfet
force-pushed
the
malfet/fix-linspace-step-computation
branch
from
a2db92f to
9014baf
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert start and end to
step_tbefore computing the differenceShould fix
torch.linspace(-2147483647, 2147483647, 10, dtype=torch.int32)Closes #40118