Skip to content

Conversation

@radkris-git
Copy link

Summary:
Pull Request resolved: pytorch/glow#4606

[PyPer][quant] Move quantized embedding operators to OSS.

This is the first step in supporting Graph Mode Quantization for EmbeddingBag.

The next steps would be
a) Implementation of Embedding prepack/unpack operators,
b) Implementation of torch.nn.quantized.dynamic.EmbeddingBag Module,
c) Implementation of torch.nn.quantized.EmbeddingBag Module,
d) Implementation (modification) of IR passes to support graph quantization of EmbeddingBag module.

More in-depth details regarding each step will be in the follow up diffs. Consider this as an initial diff that moves operators to respective places that's required for us to proceed.

Test Plan: buck test test:quantization -- '.*TestQuantizedEmbeddingBag.*

Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@dr-ci
Copy link

dr-ci bot commented Jun 16, 2020

💊 CI failures summary and remediations

As of commit 3e0f0b9 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 52 times.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@radkris-git radkris-git force-pushed the export-D21949828 branch 2 times, most recently from 9f92992 to 5cf22b8 Compare June 25, 2020 08:34
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

Summary:
Pull Request resolved: pytorch#40076

Pull Request resolved: pytorch/glow#4606

[PyPer][quant] Add quantized embedding operators to OSS.

This is the first step in supporting Graph Mode Quantization for EmbeddingBag.

At a high level, the next steps would be
a) Implementation of Embedding prepack/unpack operators,
b) Implementation of torch.nn.quantized.dynamic.EmbeddingBag Module,
c) Implementation of torch.nn.quantized.EmbeddingBag Module,
d) Implementation (modification) of IR passes to support graph quantization of EmbeddingBag module.

More in-depth details regarding each step will be in the follow up diffs. Consider this as an initial diff that moves operators to respective places that's required for us to proceed.

Test Plan: ```buck test mode/no-gpu caffe2/test:quantization -- --stress-runs 100  test_embedding_bag```

Reviewed By: supriyar

Differential Revision: D21949828

fbshipit-source-id: 47762368b5d08fe38a5e529b58452995477a6e1b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21949828

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f41173b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants