[ONNX]Fix export of full_like #40063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@neginraoof @BowenBao please review |
💊 CI failures summary and remediationsAs of commit 3ec897e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 25 times. |
neginraoof
reviewed
Jun 17, 2020
Contributor
neginraoof
left a comment
neginraoof
left a comment
There was a problem hiding this comment.
Thanks! Can you add a test for this use-case of full_like?
zou3519
added
the
triaged
neginraoof
reviewed
Jun 25, 2020
neginraoof
approved these changes
Jun 30, 2020
Contributor
Author
|
@houseroad can you please review? Thanks |
Contributor
Author
|
@houseroad can you please take a look? Thanks. |
houseroad
approved these changes
Jul 6, 2020
| ir_version: 6 | ||
| producer_name: "pytorch" | ||
| producer_version: "XXX" | ||
| producer_version: "1.7" |
Member
There was a problem hiding this comment.
Is this expect file still used?
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@houseroad merged this pull request in b2cc8a2. |
csarofeen
pushed a commit
to csarofeen/pytorch
that referenced
this pull request
Jul 7, 2020
Summary: Fix export of full_like when fill_value is of type torch._C.Value. This PR fixes a bug when exporting GPT2DoubleHeadsModel huggingface/transformers#4950 Pull Request resolved: pytorch#40063 Reviewed By: hl475 Differential Revision: D22398353 Pulled By: houseroad fbshipit-source-id: 6980a61211fe571c2e4a57716970f474851d811e
csarofeen
added a commit
to csarofeen/pytorch
that referenced
this pull request
Aug 16, 2020
This reverts commit 20e0ad7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix export of full_like when fill_value is of type torch._C.Value.
This PR fixes a bug when exporting GPT2DoubleHeadsModel huggingface/transformers#4950