Skip to content

Setter for real and imag tensor attributes #39860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anjali411 wants to merge 16 commits into from
Closed

Setter for real and imag tensor attributes #39860

anjali411 wants to merge 16 commits into from

Conversation

@anjali411
Copy link
Contributor

@anjali411 anjali411 commented Jun 11, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D22163234

@anjali411 anjali411 requested review from albanD and apaszke as code owners June 11, 2020 14:56
@anjali411 anjali411 mentioned this pull request Jun 11, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Jun 11, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit cea0162 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 121 times.

@anjali411 anjali411 requested a review from mruberry June 11, 2020 16:03
@anjali411 anjali411 added the module: complex Related to complex number support in PyTorch label Jun 11, 2020
anjali411 added a commit that referenced this pull request Jun 11, 2020
@anjali411
Setter for real and imag tensor attributes
1d5bd46 
ghstack-source-id: a0063f0
Pull Request resolved: #39860
anjali411 added a commit that referenced this pull request Jun 11, 2020
@anjali411
Setter for real and imag tensor attributes
a9a1652 
ghstack-source-id: ae213f6
Pull Request resolved: #39860
anjali411 added a commit that referenced this pull request Jun 12, 2020
@anjali411
Setter for real and imag tensor attributes
53d7c8e 
ghstack-source-id: 136f549
Pull Request resolved: #39860
anjali411 added a commit that referenced this pull request Jun 12, 2020
@anjali411
Setter for real and imag tensor attributes
cf8190d 
ghstack-source-id: df05cc9
Pull Request resolved: #39860
@mruberry mruberry removed the request for review from apaszke June 12, 2020 20:04
mruberry
mruberry reviewed Jun 12, 2020
View reviewed changes
mruberry
mruberry reviewed Jun 12, 2020
View reviewed changes
mruberry
mruberry reviewed Jun 12, 2020
View reviewed changes
mruberry
mruberry reviewed Jun 12, 2020
View reviewed changes
mruberry
mruberry reviewed Jun 12, 2020
View reviewed changes
anjali411 added a commit that referenced this pull request Jun 15, 2020
@anjali411
Setter for real and imag tensor attributes
9ac92cd 
ghstack-source-id: 1dddaf3
Pull Request resolved: #39860
anjali411 added a commit that referenced this pull request Jun 16, 2020
@anjali411
Setter for real and imag tensor attributes
ce89046 
ghstack-source-id: 2e6eaf6
Pull Request resolved: #39860
@mruberry
Copy link
Collaborator

mruberry commented Jun 16, 2020

Additional question: how will this work in C++? What's up with the derivatives.yaml entries for real and imag being removed by the view_as_real and view_as_complex PR? Will you be able to backward after performing .real?

@albanD
Copy link
Collaborator

albanD commented Jun 16, 2020

I don't know about the c++ api.
But "Will you be able to backward after performing .real?" the answer is yes. at::real() is now a composite function. And so only the derivatives of its constituents is needed (view_as_real + select).

anjali411 added a commit that referenced this pull request Jun 17, 2020
@anjali411
Setter for real and imag tensor attributes
5af9dde 
ghstack-source-id: 9ed9d6d
Pull Request resolved: #39860
anjali411 added a commit that referenced this pull request Jun 19, 2020
@anjali411
Setter for real and imag tensor attributes
ff7b441 
ghstack-source-id: 2afdbd9
Pull Request resolved: #39860
anjali411 added a commit that referenced this pull request Jun 22, 2020
@anjali411
Setter for real and imag tensor attributes
1f75eed 
ghstack-source-id: c214ca6
Pull Request resolved: #39860
anjali411 added a commit that referenced this pull request Jun 24, 2020
@anjali411
Setter for real and imag tensor attributes
f31e4ae 
ghstack-source-id: 15d8e71
Pull Request resolved: #39860
@anjali411 anjali411 requested a review from mruberry June 24, 2020 16:24
mruberry
mruberry approved these changes Jun 25, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

anjali411 added a commit that referenced this pull request Jun 26, 2020
@anjali411
Setter for real and imag tensor attributes
a078055 
ghstack-source-id: a5cc997
Pull Request resolved: #39860
anjali411 added a commit that referenced this pull request Jun 29, 2020
@anjali411
Setter for real and imag tensor attributes
3f25511 
ghstack-source-id: 505cb74
Pull Request resolved: #39860
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 30, 2020

@anjali411 merged this pull request in 11a74a5.

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 30, 2020

@anjali411 merged this pull request in 11a74a5.

@facebook-github-bot facebook-github-bot deleted the gh/anjali411/33/head branch July 3, 2020 14:16
@anjali411 anjali411 mentioned this pull request Jan 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anjali411 @mruberry @albanD @facebook-github-bot