Skip to content

Have __sizeof__ account for size of stored elements #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezyang merged 2 commits into from
Nov 27, 2017
Merged

Have __sizeof__ account for size of stored elements #3821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f13c776
Have __sizeof__ account for size of stored elements
lantiga Nov 22, 2017
b17b98e
Conform to sizeof specification
lantiga Nov 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/test_torch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4349,6 +4349,19 @@ def test_print(self):
x.__repr__()
str(x),

def test_sizeof(self):
sizeof_empty = torch.randn(0).storage().__sizeof__()
sizeof_10 = torch.randn(10).storage().__sizeof__()
sizeof_100 = torch.randn(100).storage().__sizeof__()
self.assertEqual((sizeof_100 - sizeof_empty) // (sizeof_10 - sizeof_empty), 10)
self.assertEqual((sizeof_100 - sizeof_empty) % (sizeof_10 - sizeof_empty), 0)

sizeof_empty = torch.randn(0).type(torch.ByteTensor).storage().__sizeof__()
sizeof_10 = torch.randn(10).type(torch.ByteTensor).storage().__sizeof__()
sizeof_100 = torch.randn(100).type(torch.ByteTensor).storage().__sizeof__()
self.assertEqual((sizeof_100 - sizeof_empty) // (sizeof_10 - sizeof_empty), 10)
self.assertEqual((sizeof_100 - sizeof_empty) % (sizeof_10 - sizeof_empty), 0)

def test_unsqueeze(self):
x = torch.randn(2, 3, 4)
y = x.unsqueeze(1)
Expand Down
3 changes: 3 additions & 0 deletions torch/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ def __deepcopy__(self, memo):
def __reduce__(self):
return type(self), (self.tolist(),)

def __sizeof__(self):
return super(_StorageBase, self).__sizeof__() + self.element_size() * self.size()

def clone(self):
"""Returns a copy of this storage"""
return type(self)(self.size()).copy_(self)
Expand Down