Make integer parameters and buffers immune to float(), double() and half() #3820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
can you add tests please. |
Contributor
Author
|
Yep, I'm on it |
Contributor
Author
|
@pytorchbot retest this please |
apaszke
approved these changes
Nov 22, 2017
Contributor
apaszke
left a comment
apaszke
left a comment
There was a problem hiding this comment.
It would be nice to be able to retrieve this from the type somehow (e.g. to have sth like NumPy dtype objects), but this probably needs some more discussion. Looks good.
Contributor
|
thanks a lot Luca! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #3810