[ONNX] Fix scalar type cast for comparison ops #37787

BowenBao · 2020-05-04T19:19:15Z

Always promote type casts for comparison operators, regardless if the input is tensor or scalar. Unlike arithmetic operators, where scalars are implicitly cast to the same type as tensors.

dr-ci · 2020-05-04T19:20:33Z

💊 CI failures summary and remediations

As of commit 20ea90f (more details on the Dr. CI page):

3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_macos_10_13_py3_test (1/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Aug 03 16:30:17 clang: error: linker command failed with exit code 1 (use -v to see invocation)

Aug 03 16:30:17      
Aug 03 16:30:17     creating build/temp.macosx-10.9-x86_64-3.8/numba/cext 
Aug 03 16:30:17     compile options: '-I/Users/distiller/workspace/miniconda3/lib/python3.8/site-packages/numpy/core/include -I/Users/distiller/workspace/miniconda3/include/python3.8 -c' 
Aug 03 16:30:17     extra options: '-g' 
Aug 03 16:30:17     clang: numba/_helpermod.cclang: numba/cext/utils.c 
Aug 03 16:30:17      
Aug 03 16:30:17     clang: numba/cext/dictobject.c 
Aug 03 16:30:17     clang: numba/cext/listobject.c 
arch x86_64 -L/Users/distiller/workspace/miniconda3/lib -arch x86_64 -arch x86_64 build/temp.macosx-10.9-x86_64-3.8/numba/_helpermod.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/utils.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/dictobject.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/listobject.o -L/Users/distiller/workspace/miniconda3/lib/python3.8/site-packages/numpy/core/lib -lnpymath -o build/lib.macosx-10.9-x86_64-3.8/numba/_helperlib.cpython-38-darwin.so -headerpad_max_install_names 
Aug 03 16:30:17     ld: in /Users/distiller/workspace/miniconda3/lib/python3.8/site-packages/numpy/core/lib/libnpymath.a(npy_math.o), could not parse object file /Users/distiller/workspace/miniconda3/lib/python3.8/site-packages/numpy/core/lib/libnpymath.a(npy_math.o): 'Unknown attribute kind (61) (Producer: 'LLVM10.0.0' Reader: 'LLVM APPLE_1_902.0.39.2_0')', using libLTO version 'LLVM version 9.1.0, (clang-902.0.39.2)' for architecture x86_64 
Aug 03 16:30:17     clang: error: linker command failed with exit code 1 (use -v to see invocation) 
ler/workspace/miniconda3/lib -arch x86_64 -arch x86_64 build/temp.macosx-10.9-x86_64-3.8/numba/_helpermod.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/utils.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/dictobject.o build/temp.macosx-10.9-x86_64-3.8/numba/cext/listobject.o -L/Users/distiller/workspace/miniconda3/lib/python3.8/site-packages/numpy/core/lib -lnpymath -o build/lib.macosx-10.9-x86_64-3.8/numba/_helperlib.cpython-38-darwin.so -headerpad_max_install_names" failed with exit status 1 
Aug 03 16:30:17     ---------------------------------------- 
d3j9r52rv80000gn/T/pip-install-yj_02lny/numba/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/var/folders/gk/lkr9pm5x039fx6d3j9r52rv80000gn/T/pip-record-fbpx2lik/install-record.txt --single-version-externally-managed --compile --install-headers /Users/distiller/workspace/miniconda3/include/python3.8/numba Check the logs for full command output. 
Aug 03 16:30:17 + cleanup 
Aug 03 16:30:17 + retcode=1 
Aug 03 16:30:17 + set +x

pytorch_linux_xenial_py3_6_gcc5_4_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/config.yml 
Auto-merging .circleci/config.yml 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py 
Auto-merging .circleci/cimodel/data/windows_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/binary_smoketest.py 
Auto-merging .circleci/cimodel/data/simple/binary_smoketest.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py 
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_data.py 
Auto-merging .circleci/cimodel/data/binary_build_data.py 
Automatic merge failed; fix conflicts and then commit the result.

pytorch_xla_linux_bionic_py3_6_clang9_build (3/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/config.yml 
Auto-merging .circleci/config.yml 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py 
Auto-merging .circleci/cimodel/data/windows_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/binary_smoketest.py 
Auto-merging .circleci/cimodel/data/simple/binary_smoketest.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py 
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_data.py 
Auto-merging .circleci/cimodel/data/binary_build_data.py 
Automatic merge failed; fix conflicts and then commit the result.

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 32 times.

BowenBao · 2020-05-04T19:21:01Z

cc @jacky82226

BowenBao · 2020-05-05T22:21:04Z

Test TestONNXRuntime_opset11.test_mask_rcnn failing with

E       onnxruntime.capi.onnxruntime_pybind11_state.NotImplemented: [ONNXRuntimeError] : 9 : NOT_IMPLEMENTED : Could not find an implementation for the node Greater_1611:Greater(9)

This PR is currently blocked due to that Greater[double] is not supported in onnxruntime.

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad

Any update on this PR?

BowenBao · 2020-06-30T00:38:10Z

Any update on this PR?

Will submit a fix to ONNXRuntime to unblock this.

bzinodev

Need Microsoft approvers

torch/csrc/jit/passes/onnx/scalar_type_analysis.cpp

test/onnx/test_pytorch_onnx_onnxruntime.py

neginraoof

Thanks. Had a couple comments.

BowenBao · 2020-07-29T21:11:17Z

The CI failure needs a fix from ONNXRuntime, which is already in master and will be reflected in 7.29's nightly build.

neginraoof

LGTM. Thanks!

BowenBao · 2020-08-07T17:07:28Z

@bzinodev Can you import this PR for merge? Thanks.

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-08-10T06:10:56Z

@houseroad merged this pull request in 55ac240.

BowenBao requested a review from apaszke as a code owner May 4, 2020 19:19

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 4, 2020

pytorchbot added the open source label May 4, 2020

ngimel requested a review from houseroad May 5, 2020 01:22

ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 5, 2020

facebook-github-bot reviewed May 6, 2020

View reviewed changes

jcwchen mentioned this pull request May 11, 2020

Catch >2GB models in checker onnx/onnx#2744

Merged

houseroad reviewed Jun 28, 2020

View reviewed changes

BowenBao mentioned this pull request Jun 30, 2020

Support double type for Greater CPU microsoft/onnxruntime#4373

Merged

bzinodev self-requested a review July 16, 2020 19:41

bzinodev approved these changes Jul 16, 2020

View reviewed changes

bzinodev suggested changes Jul 16, 2020

View reviewed changes

BowenBao added 2 commits July 23, 2020 15:09

Fix scalar type cast for comparison ops

236b280

clang format

6696407

BowenBao force-pushed the onnx_comparison_cast branch from 7981029 to 6696407 Compare July 23, 2020 22:09

BowenBao added 2 commits July 23, 2020 16:33

update ort to include fix

8ecf124

update ort version

915d15e

neginraoof reviewed Jul 24, 2020

View reviewed changes

torch/csrc/jit/passes/onnx/scalar_type_analysis.cpp Show resolved Hide resolved

neginraoof reviewed Jul 24, 2020

View reviewed changes

test/onnx/test_pytorch_onnx_onnxruntime.py Outdated Show resolved Hide resolved

neginraoof reviewed Jul 24, 2020

View reviewed changes

neginraoof mentioned this pull request Jul 24, 2020

[ONNX] Where op #41544

Closed

neginraoof mentioned this pull request Jul 29, 2020

[ONNX] Export KLDivLoss #41858

Closed

BowenBao and others added 3 commits July 29, 2020 14:42

add more test case

bdf769b

bump ort version

f0143fb

bump ort version2

20ea90f

neginraoof approved these changes Aug 5, 2020

View reviewed changes

bzinodev approved these changes Aug 6, 2020

View reviewed changes

facebook-github-bot reviewed Aug 7, 2020

View reviewed changes

facebook-github-bot closed this in 55ac240 Aug 10, 2020

facebook-github-bot added the merged label Aug 10, 2020

mruberry added the Merged label Oct 28, 2020

[ONNX] Fix scalar type cast for comparison ops #37787

[ONNX] Fix scalar type cast for comparison ops #37787

Uh oh!

Conversation

BowenBao commented May 4, 2020

Uh oh!

dr-ci bot commented May 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 3 new failures recognized by patterns

pytorch_macos_10_13_py3_test (1/3)

pytorch_linux_xenial_py3_6_gcc5_4_build (2/3)

pytorch_xla_linux_bionic_py3_6_clang9_build (3/3)

Uh oh!

BowenBao commented May 4, 2020

Uh oh!

BowenBao commented May 5, 2020

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

houseroad left a comment

Choose a reason for hiding this comment

Uh oh!

BowenBao commented Jun 30, 2020

Uh oh!

bzinodev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

neginraoof left a comment

Choose a reason for hiding this comment

Uh oh!

BowenBao commented Jul 29, 2020

Uh oh!

neginraoof left a comment

Choose a reason for hiding this comment

Uh oh!

BowenBao commented Aug 7, 2020

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Aug 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dr-ci bot commented May 4, 2020 •

edited

Loading