Skip to content

Fix CUDA builds for Windows #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 2 commits into from
Nov 12, 2017
Merged

Fix CUDA builds for Windows #3650

soumith merged 2 commits into from
Nov 12, 2017

Conversation

@peterjc123
Copy link
Collaborator

@peterjc123 peterjc123 commented Nov 12, 2017 •
edited
Loading

  1. CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS has a limitation, the maximum number of exported functions cannot exceed 65535. So it can't be used in CUDA builds. Removing this.
  2. Specify static on an inline function to prevent linking errors. The MSVC uses C89 standard that will expose the inline function if it's not static.

@peterjc123
Fix CUDA builds for Windows
d019641 
1. CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS has a limitation, the maximum number of exported functions cannot exceed 65535. So it can't be used.
2. Specify static on an inline function to prevent linking errors.
@peterjc123
cancel CMAKE version limitation
1e9b034
@peterjc123 peterjc123 mentioned this pull request Nov 12, 2017
Closed
@soumith soumith merged commit ea4432b into pytorch:master Nov 12, 2017
@soumith
Copy link
Contributor

soumith commented Nov 12, 2017

thank you!

@peterjc123 peterjc123 deleted the script_fix branch November 12, 2017 05:20
@mthrok mthrok mentioned this pull request Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterjc123 @soumith @ezyang