Skip to content

Conversation

@gchanan
Copy link
Contributor

@gchanan gchanan commented Nov 9, 2017

  1. Test forward with requires_grad=False (this wasn't currently broken but was reported recently).
  2. Test forward with requires_grad=True (this was actually fixed recently in ATen when making size/stride native functions)
  3. Fix and test backwards. This required changing the gradient formula and also changing gradcheck to support empty inputs.

Gradgradcheck fails due to some size issues that don't look related to the formula for this specific function. It may not be able to handle multiple outputs where some are empty tensors.

@soumith
Copy link
Contributor

soumith commented Dec 18, 2017

@gchanan can you rebase this?

@soumith soumith merged commit 58f6008 into pytorch:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants