Add ONNX symbolic for UpsamplingNearest2d #3450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houseroad
force-pushed
the
upsamplingnearest2d
branch
from
c874a9a to
2a517c0
Compare
ezyang
reviewed
Nov 4, 2017
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
previously requested changes
Nov 4, 2017
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Use the helper function here. Also, we should export this as a Caffe2 vendor extension op while it is not supported in ONNX (talk to me about how to do this.)
Member
Author
|
Just realize that this one is a little bit tricky, since ATen has no corresponding implementation. |
houseroad
force-pushed
the
upsamplingnearest2d
branch
from
2a517c0 to
3779101
Compare
Member
Author
|
onnx/onnx#180, now we have it as an experimental op. Later we may polish it. I think upsample op is useful/necessary. |
Collaborator
|
Build finished. |
1 similar comment
Collaborator
|
Build finished. |
Member
Author
|
I think Dima already updated the symbolic. But it got changed in ONNX, so I will update this PR to fix the problem. |
houseroad
force-pushed
the
upsamplingnearest2d
branch
from
3779101 to
62ba644
Compare
dzhulgakov
approved these changes
Nov 29, 2017
houseroad
force-pushed
the
upsamplingnearest2d
branch
from
62ba644 to
3d15ef3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the symbolic for UpsamplingNearest2d.
Locally tested on test_operators.py and test_caffe2.py.
Will update ONNX and ONNX-Caffe2 later.