Allow empty index tensor for index_select #3429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killeent
suggested changes
Nov 2, 2017
test/test_torch.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
colesbury
reviewed
Nov 6, 2017
| THArgCheck(indices->nDimension == 1, 3, "Index is supposed to be a vector"); | ||
| THArgCheck(indices->nDimension <= 1, 3, "Index is supposed to be an empty tensor or a vector"); | ||
|
|
||
| THCudaLongTensor *indices_ = THCudaLongTensor_newWithSize1d(state, indices->size[0]); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3416 .
Test:
Verified the snippet in #3416 runs on both cpu and cuda. Verified that
TestTorch.test_advancedindexandTestCuda.test_advancedindexpasses with the new inserted assertion.