Skip to content

Clear out eigenvector tensor when eigenvector=F for symeig #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 1 commit into from
Nov 1, 2017
Merged

Clear out eigenvector tensor when eigenvector=F for symeig #3411

soumith merged 1 commit into from
Nov 1, 2017

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented Oct 31, 2017 •
edited
Loading

Fixes #2088.

Previously when eigenvector=False symeig returns some value for the eigenvectors. This zeros them out. Not sure if this is 100% necessary because it does impact performance a little, but it is nice if someone makes a mistake and tries to use them.

Test Plan

import torch as th
x = th.ones(10,10)
[e,V] = th.symeig(x, eigenvectors=True)
print(V) # presumably the eigenvectors
[e,V] = th.symeig(x, eigenvectors=False) 
print(V) # assert prints zeros

@soumith soumith merged commit d905a90 into pytorch:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@apaszke apaszke apaszke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zou3519 @apaszke @soumith