Skip to content

[jit] fix up refs in overview.md #33919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
suo wants to merge 2 commits into from
Closed

[jit] fix up refs in overview.md #33919

suo wants to merge 2 commits into from

Conversation

@suo
Copy link
Member

@suo suo commented Feb 27, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D20154953

@suo suo requested a review from apaszke as a code owner February 27, 2020 23:45
@suo suo mentioned this pull request Feb 27, 2020
Closed
suo added a commit that referenced this pull request Feb 27, 2020
@suo
[jit] fix up refs in overview.md
ddb0bb6 
ghstack-source-id: 38fe632
Pull Request resolved: #33919
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Feb 27, 2020
@suo suo requested review from driazati and zdevito February 28, 2020 00:01
driazati
driazati approved these changes Feb 28, 2020
View reviewed changes
torch/csrc/jit/OVERVIEW.md

* named Parameters - tensors used in training such as `weight` or `bias`
* named Methods - functions that can be run on the module such as `forward`
* named Buffers - tensors that are part of the training state of a module but do not appear in module.parameters() and do not participate in gradient descent.
Copy link
Contributor

@driazati driazati Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buffers are the same as tensor attributes, they should probably be in the same bullet

Copy link
Member Author

@suo suo Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's more an implementation detail; since the api has buffers() and named_buffers() I thought we might want to call them out specifically.

@dr-ci
Copy link

dr-ci bot commented Feb 28, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 001fe61:

None of the build failures appear to be your fault.

  • 1/1 broken upstream at merge base d975609 since Feb 27

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
git rebase --onto viable/strict $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch origin viable/strict
git rebase viable/strict

    Check out the recency history of this "viable master" tracking branch.

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🚧 1 upstream failure recognized by patterns:

These builds matched patterns, but were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 1 time.

suo added a commit that referenced this pull request Feb 28, 2020
@suo
[jit] fix up refs in overview.md
98eb95a 
ghstack-source-id: 4b7d2eb
Pull Request resolved: #33919
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 28, 2020

@suo merged this pull request in 8f84ded.

hczhu pushed a commit that referenced this pull request Feb 28, 2020
@suo
[jit] fix up refs in overview.md (#33919)
9756a39 
Summary: Pull Request resolved: #33919

Test Plan: Imported from OSS

Differential Revision: D20154953

Pulled By: suo

fbshipit-source-id: 2ef83cce8da88212bed7edc813c9b233267ea81b
@facebook-github-bot facebook-github-bot deleted the gh/suo/275/head branch March 2, 2020 15:17
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
@suo @ttumiel
[jit] fix up refs in overview.md (pytorch#33919)
b1dc30a 
Summary: Pull Request resolved: pytorch#33919

Test Plan: Imported from OSS

Differential Revision: D20154953

Pulled By: suo

fbshipit-source-id: 2ef83cce8da88212bed7edc813c9b233267ea81b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

@zdevito zdevito Awaiting requested review from zdevito

1 more reviewer

@driazati driazati driazati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suo @facebook-github-bot @driazati @mruberry