Skip to content

[jit] add top-level readme to csrc/jit #33916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
suo wants to merge 2 commits into from
Closed

[jit] add top-level readme to csrc/jit #33916

suo wants to merge 2 commits into from

Conversation

@suo
Copy link
Member

@suo suo commented Feb 27, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D20150771

@suo suo requested a review from apaszke as a code owner February 27, 2020 23:23
suo added a commit that referenced this pull request Feb 27, 2020
@suo
[jit] add top-level readme to csrc/jit
946ccbc 
ghstack-source-id: a4b9bae
Pull Request resolved: #33916
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Feb 27, 2020
@suo suo requested review from driazati and zdevito February 27, 2020 23:31
driazati
driazati approved these changes Feb 27, 2020
View reviewed changes
torch/csrc/jit/README.md
- `python/`: Binding stuff into Python or accessing information from the Python environment.
- `testing/`: Utilities and helpers for testing.
- `mobile/`: Mobile-specific implementations of runtime components.
- `passes/`: IR-to-IR passes, generally for optimization and lowering.
Copy link
Contributor

@driazati driazati Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a bit about the existing backends, generated, codegen tensorexpr, and testing folders

Copy link
Member Author

@suo suo Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think codegen and testing are already documented. I plan to move tensorexpr under codegen. And backends is to be deleted shortly. I'll add a note about generated.

@suo suo mentioned this pull request Feb 27, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Feb 27, 2020

💊 CircleCI build failures summary and remediations

As of commit 33302f5:

None of the build failures appear to be your fault.

  • 1/1 broken upstream at merge base d975609 since Feb 27

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
git rebase --onto viable/strict $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch origin viable/strict
git rebase viable/strict

    Check out the recency history of this "viable master" tracking branch.

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🚧 1 upstream failure recognized by patterns:

These builds matched patterns, but were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 28, 2020

@suo merged this pull request in d6485b4.

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 28, 2020

@suo merged this pull request in d6485b4.

hczhu pushed a commit that referenced this pull request Feb 28, 2020
@suo
[jit] add top-level readme to csrc/jit (#33916)
ca4ae46 
Summary: Pull Request resolved: #33916

Test Plan: Imported from OSS

Differential Revision: D20150771

Pulled By: suo

fbshipit-source-id: c7550954ddd6a294ce833348bf9fa058503e9bd7
@facebook-github-bot facebook-github-bot deleted the gh/suo/273/head branch March 2, 2020 15:17
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
@suo @ttumiel
[jit] add top-level readme to csrc/jit (pytorch#33916)
d9c8dd2 
Summary: Pull Request resolved: pytorch#33916

Test Plan: Imported from OSS

Differential Revision: D20150771

Pulled By: suo

fbshipit-source-id: c7550954ddd6a294ce833348bf9fa058503e9bd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

@zdevito zdevito Awaiting requested review from zdevito

1 more reviewer

@driazati driazati driazati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suo @facebook-github-bot @driazati @mruberry