Move QScheme ops to c10 #30134
Closed
Move QScheme ops to c10 #30134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D18609716](https://our.internmc.facebook.com/intern/diff/D18609716/) [ghstack-poisoned]
xcheng16
pushed a commit
that referenced
this pull request
Nov 20, 2019
Differential Revision: [D18609716](https://our.internmc.facebook.com/intern/diff/D18609716/) ghstack-source-id: 94249120 Pull Request resolved: #30134
Differential Revision: [D18609716](https://our.internmc.facebook.com/intern/diff/D18609716/) [ghstack-poisoned]
xcheng16
pushed a commit
that referenced
this pull request
Dec 3, 2019
Pull Request resolved: #30134 ghstack-source-id: 94798586 Differential Revision: [D18609716](https://our.internmc.facebook.com/intern/diff/D18609716/)
Differential Revision: [D18609716](https://our.internmc.facebook.com/intern/diff/D18609716/) [ghstack-poisoned]
xcheng16
pushed a commit
that referenced
this pull request
Dec 5, 2019
Pull Request resolved: #30134 ghstack-source-id: 95012521 Differential Revision: [D18609716](https://our.internmc.facebook.com/intern/diff/D18609716/)
smessmer
approved these changes
Dec 5, 2019
Contributor
smessmer
left a comment
smessmer
left a comment
There was a problem hiding this comment.
looks good, assuming CI passes
aten/src/ATen/core/jit_type.h
Outdated
| struct CAFFE2_API QschemeType : public Type { | ||
| static QschemeTypePtr create() { | ||
| return QschemeTypePtr( | ||
| new QschemeType()); // NOLINT(modernize-make-shared) |
Contributor
There was a problem hiding this comment.
let's use make_shared here
aten/src/ATen/core/jit_type.h
Outdated
| GeneratorType() : Type(TypeKind::GeneratorType) {} | ||
| }; | ||
|
|
||
| struct QschemeType; |
Contributor
There was a problem hiding this comment.
I think the naming convention is QScheme, not Qscheme
aten/src/ATen/core/jit_type.h
Outdated
| return "Qscheme"; | ||
| } | ||
| static const TypeKind Kind = TypeKind::QschemeType; | ||
| // global singletonq |
Differential Revision: [D18609716](https://our.internmc.facebook.com/intern/diff/D18609716/) [ghstack-poisoned]
Differential Revision: [D18609716](https://our.internmc.facebook.com/intern/diff/D18609716/) [ghstack-poisoned]
xcheng16
pushed a commit
that referenced
this pull request
Dec 6, 2019
Pull Request resolved: #30134 ghstack-source-id: 95055387 Differential Revision: [D18609716](https://our.internmc.facebook.com/intern/diff/D18609716/)
25 tasks
Contributor
|
This pull request has been merged in 81e4739. |
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#30134 ghstack-source-id: 95055387 Test Plan: buck build mode/dev caffe2:generate-code Differential Revision: D18609716 fbshipit-source-id: fec39359e0b97387a9b13f8179d72a731cc61808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18609716