[ATEN->C10] Migrate return type void to () for native functions. #28290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/) [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
xcheng16
pushed a commit
that referenced
this pull request
Oct 18, 2019
Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/) ghstack-source-id: 91245072 Pull Request resolved: #28290
added 2 commits
October 18, 2019 09:49
…tions." Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/) [ghstack-poisoned]
…tions." Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/) [ghstack-poisoned]
xcheng16
pushed a commit
that referenced
this pull request
Oct 19, 2019
Pull Request resolved: #28290 ghstack-source-id: 92258422 Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/)
…tions." Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/) [ghstack-poisoned]
xcheng16
pushed a commit
that referenced
this pull request
Oct 21, 2019
Pull Request resolved: #28290 ghstack-source-id: 92269400 Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/)
…tions." Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/) [ghstack-poisoned]
xcheng16
pushed a commit
that referenced
this pull request
Oct 21, 2019
Pull Request resolved: #28290 ghstack-source-id: 92272727 Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/)
…tions." Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/) [ghstack-poisoned]
xcheng16
pushed a commit
that referenced
this pull request
Oct 22, 2019
Pull Request resolved: #28290 ghstack-source-id: 92368250 Differential Revision: [D17565528](https://our.internmc.facebook.com/intern/diff/D17565528/)
25 tasks
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 22, 2019
Summary: Pull Request resolved: pytorch/pytorch#28290 ghstack-source-id: 92368250 Test Plan: Pull Request resolved: pytorch/pytorch#28290 ghstack-source-id: 92368250 Differential Revision: D17565528 fbshipit-source-id: f4870bb9ee4f4e7c48df4d68508b512d25ed277c
Contributor
|
This pull request has been merged in 177c95e. |
Contributor
|
Why is there no motivation provided for this change? CC @smessmer. |
Contributor
|
|
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28290 ghstack-source-id: 92368250 Test Plan: Pull Request resolved: pytorch#28290 ghstack-source-id: 92368250 Differential Revision: D17565528 fbshipit-source-id: f4870bb9ee4f4e7c48df4d68508b512d25ed277c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D17565528