Fix overload names #28182
Closed
Fix overload names #28182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
This was referenced Oct 17, 2019
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
ezyang
approved these changes
Oct 17, 2019
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
But why wasn't this caught in our existing tests?
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
Contributor
Author
|
@ezyang because globalATenDispatch doesn't enforce overload names to be unique but c10 does |
Contributor
|
I am suggesting that the native functions parser should check overload names for uniqueness |
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
zdevito
approved these changes
Oct 18, 2019
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
Closed
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
They haven't been unique. Fixing it... Differential Revision: [D17969010](https://our.internmc.facebook.com/intern/diff/D17969010/) [ghstack-poisoned]
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 23, 2019
Summary: Pull Request resolved: pytorch/pytorch#28182 They haven't been unique. Fixing it... ghstack-source-id: 92436985 Test Plan: waitforsandcastle Differential Revision: D17969010 fbshipit-source-id: 1aacbfb3c18a75ca6743b03cc2eea5fc4d3685c9
Contributor
|
This pull request has been merged in 005d6ea. |
25 tasks
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28182 They haven't been unique. Fixing it... ghstack-source-id: 92436985 Test Plan: waitforsandcastle Differential Revision: D17969010 fbshipit-source-id: 1aacbfb3c18a75ca6743b03cc2eea5fc4d3685c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
They haven't been unique. Fixing it...
Differential Revision: D17969010