Add unsupported types to schema type parser #28181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
This was referenced Oct 17, 2019
Closed
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
Contributor
|
I'm pretty sure I don't want ConstQuantizerPtr permanently in the list. @jerryzh168 you have previously told me this name is temporary. What is the plan? At the VERY least the types we aren't going to stick to should be prominently documented as such. |
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
Contributor
Author
|
I added a bunch of TODOs to these types |
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
zdevito
reviewed
Oct 18, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
Looks good except for DimnameList.
Contributor
we'll have a Quantizer type that will replace this one in the future, and it's blocked on TorchBind supporting custom times right now, @jamesr66a has signed up to work on it. |
dzhulgakov
reviewed
Oct 21, 2019
| {"QScheme", IntType::get()}, | ||
| {"Storage", IntType::get()}, | ||
| {"QScheme", IntType::get()}, // TODO This type should be removed from the schema parser, it should use the custom class mechanism instead. @jerryzh | ||
| {"ConstQuantizerPtr", IntType::get()}, // TODO This type should be removed from the schema parser, it should use the custom class mechanism instead. @jerryzh |
Collaborator
There was a problem hiding this comment.
yep, I'm fine landing it as is right now though
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
ezyang
approved these changes
Oct 22, 2019
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
This was referenced Oct 22, 2019
Closed
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. Differential Revision: [D17969014](https://our.internmc.facebook.com/intern/diff/D17969014/) [ghstack-poisoned]
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 23, 2019
Summary: Pull Request resolved: pytorch/pytorch#28181 These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. ghstack-source-id: 92436989 Test Plan: waitforsandcastle Differential Revision: D17969014 fbshipit-source-id: 41ebe256baec81ed8fb165e7b7cffa5160d285c3
Contributor
|
This pull request has been merged in a94bf1d. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28181 These types are needed to parse the schemas from native_functions.yaml. Note: This doesn't actually add the functionality to JIT, it only makes the parser pass. ghstack-source-id: 92436989 Test Plan: waitforsandcastle Differential Revision: D17969014 fbshipit-source-id: 41ebe256baec81ed8fb165e7b7cffa5160d285c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
These types are needed to parse the schemas from native_functions.yaml.
Note: This doesn't actually add the functionality to JIT, it only makes the parser pass.
Differential Revision: D17969014