[wip] Remove manual boxing wrappers #26865
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/) [ghstack-poisoned]
This was referenced Sep 26, 2019
smessmer
added a commit
that referenced
this pull request
Sep 26, 2019
Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/) ghstack-source-id: 90814942 Pull Request resolved: #26865
Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/) [ghstack-poisoned]
This was referenced Sep 26, 2019
smessmer
added a commit
that referenced
this pull request
Sep 26, 2019
Pull Request resolved: #26865 Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size ghstack-source-id: 90842816 Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/)
Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 26, 2019
Pull Request resolved: #26865 Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size ghstack-source-id: 90847798 Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/)
Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/) [ghstack-poisoned]
pytorchbot
added
the
module: internals
Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/) [ghstack-poisoned]
Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 26, 2019
Pull Request resolved: #26865 Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size ghstack-source-id: 90866994 Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/)
Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size by 600kb Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 27, 2019
Pull Request resolved: #26865 Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore. This reduces binary size ghstack-source-id: 90902005 Differential Revision: [D17594892](https://our.internmc.facebook.com/intern/diff/D17594892/)
25 tasks
Collaborator
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Ops that are already fully migrated to c10 should not have manual boxing wrappers in register_aten_ops.cpp anymore.
This reduces binary size by 600kb
Differential Revision: D17594892