Allow DataParallel returning dict and any other instances of iterable custom classes #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classes which are iterable and can be initialized with list
This was referenced Sep 7, 2017
ssnl
reviewed
Feb 1, 2018
| return type(out)(map(gather_map, zip(*outputs))) | ||
| if isinstance(out, dict): | ||
| return dict(zip(out.keys(), | ||
| map(gather_map, zip(*[d.values() for d in outputs])))) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
weiyangfb
added
the
awaiting response (this tag is deprecated)
Contributor
|
closing this because similar PR is already merged: #6113 |
weiyangfb
removed
the
awaiting response (this tag is deprecated)
samnordmann
pushed a commit
to samnordmann/pytorch
that referenced
this pull request
Mar 6, 2023
* Add prod op * Accept None/scalar dims argument in reduction ops. These are actually the only signatures accepted by the pytorch prod/min/max functions. * Add optional dtype argument to oneVal and zeroVal --------- Co-authored-by: Jacob Hinkle <jhinkle@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning a dict or instances of custom classes can be very helpful, especially for complex networks. For exmaple, the RNN state of a complex RNN model is usually wrapped inside a custom class.