Skip to content

Conversation

@Chillee
Copy link
Collaborator

@Chillee Chillee commented Aug 16, 2019

Generated with stubgen and moved from out/flatten.pyi to flatten.pyi.in.

#22245 (comment)

@Chillee Chillee requested review from ezyang and soumith August 16, 2019 06:39
@pytorchbot pytorchbot added module: nn Related to torch.nn module: typing Related to mypy type annotations labels Aug 16, 2019
@pytorchbot pytorchbot added the module: build Build system issues label Aug 16, 2019
@Chillee
Copy link
Collaborator Author

Chillee commented Aug 16, 2019

@pytorchbot merge this please

@Chillee
Copy link
Collaborator Author

Chillee commented Aug 17, 2019

@pytorchbot rebase this please

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 5a032f0.

@janosh
Copy link
Contributor

janosh commented Aug 18, 2020

I'm having a similar problem as @PistonY in #22245 (comment). Pylance is unable to find nn.Flatten.

Softmax working

Softmax working

Flatten not working

Flatten not working

@ezyang
Copy link
Contributor

ezyang commented Aug 18, 2020

@janosh please file a new issue on this; also, please check if the issue still occurs on nightly.

@janosh
Copy link
Contributor

janosh commented Aug 19, 2020

@ezyang Sorry for the noise. I was on 1.5. Updating to 1.6 fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: build Build system issues module: nn Related to torch.nn module: typing Related to mypy type annotations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants